Conversation
summit-api emits audit.entity as the concrete subclass name, so the class_name==SummitEvent filter only matched plain events and hid every Presentation, SummitEventWithFile and SummitGroupEvent record. The post-save refresh in event-actions still sent the legacy SummitEventAuditLog class name, which matches nothing on the audit-logs-api and blanked the panel after saving an event. The global audit log page, the event form audit panel and the post-save refresh now send SummitEvent||Presentation||SummitEventWithFile||SummitGroupEvent.
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Essentials Run ID: 📒 Files selected for processing (4)
Included review availability: 4 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour. 📝 WalkthroughWalkthroughEvent audit-log filters now match ChangesEvent audit-log filters
Priority: ➖ Normal Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to The event audit-log views now consistently request all four intended classes. No confirmed issue blocks merging. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Summary
The Show Admin audit views hide most event history because the entity filter they send no longer matches what
summit-apiwrites.summit-apiemitsaudit.entityas the concrete subclass name (class_basename($entity)inAuditLogOtlpStrategy), andaudit-logs-apimainnow appliesclass_nameas an exacttermonaudit.entity.keyword. With that in place:class_name==SummitEvent(global audit log page and event form panel) only matches plain events. For Summit 73 in production it returns 813 rows and drops the 10000+Presentationrows, plus everySummitEventWithFileandSummitGroupEventrecord.class_name==SummitEventAuditLog(post-save refresh inevent-actions.js) is a legacy MySQL class name that matches nothing, so the panel goes blank right after saving an event.This is the
masterport of the fix already shipped toproductionin11b7ea8fand39b9d02a.Changes
src/pages/audit-log/audit-log-page.js,src/components/forms/event-form/index.js,src/actions/event-actions.js: sendclass_name==SummitEvent||Presentation||SummitEventWithFile||SummitGroupEvent, the same four subclassessummit-apinormalizes inAuditLoggerFactory.src/pages/audit-log/__tests__/audit-log-page.test.js: assert the new filter.audit-logs-apialready supports||on a single filter field (1238e56).Verification
Against
audit-logs-api.fnvirtual.app, Summit 73:class_namefilterSummitEvent(before)SummitEvent||Presentation||SummitEventWithFile||SummitGroupEvent(after)SummitEventAuditLog(old post-save refresh)SummitEventWithFile), before / afterLocal:
yarn jest src/pages/audit-log src/actions/__tests__/event-actions.test.js src/actions/__tests__/audit-log-actions.test.js src/components/forms/event-form/__tests__ src/reducers/audit_logpasses. ESLint clean on the touched files.Related
Summary by CodeRabbit