Repository navigation
fix(deps): preserve chart hover and React version compatibility - #360
Merged
Merged
Conversation
Signed-off-by: 小爬的老粉丝 <727842003@qq.com>
Signed-off-by: 小爬的老粉丝 <727842003@qq.com>
This was referenced Oct 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
^4.1.0range, JSDOM test dependencies to 30.1.2, and modern React packages to React 19 types. Both React 17 legacy packages retain React 17 types.Related issue
N/A: coordinated dependency maintenance. This implements the updates proposed in #315, #316 and #319 with compatibility fixes, and preserves the unique visual contribution from #326.
Change classification
Verification
All checks below completed locally on Node 26.8.2 and pnpm 11.0.9. The normal frozen install used a new independent dependency directory, store and metadata cache; the lockfile did not change.
pnpm install --frozen-lockfilewith fresh task store/cachepnpm buildpnpm type-checkpnpm testpnpm verify:github-governancepnpm --filter @file-viewer/pptx verify:chart-familiesThe two real hover-focus checks fail before the renderer fix. After the fix, the browser checks pass at DPR 1 and 2 with no external requests or uncaught browser errors. Public CI now runs this chart gate after the existing issue regressions.
Sample / fixture evidence
packages/renderers/text/test/single-byte-encodings/fixtures.mjssupplies the existing bounded text fixtures and exact search-offset checks.docs/regressions/text-single-byte-encodings/original-before-after.pngpreserves the original public image from 4gray's PR fix(text): decode Latin-1 and other single-byte txt files instead of GB18030 #326, commitb957c2be56e753a05889fbb3828e950cc4277d1d.Visual evidence
After a real mouse hover on the stacked chart:
The generated doughnut retains its 75 percent hole ratio:
Risk and compatibility
^22.22.2 || ^24.15.0 || >=26.0.0. Public CI uses Node 24; consumer runtime requirements remain unchanged.Checklist