Repository navigation
fix: adopt DOCX and verify renderer runtimes and full assets - #350
Merged
wybaby168 merged 10 commits intoOct 9, 2026
Merged
Conversation
Combine current-base PRs #348, #346, #349 and #347 and preserve newer main changes while restoring reviewed renderer and package boundaries. Prepared and validated by Codex <codex@openai.com> in an independent cloud workspace. Local candidate: 7f478f7e0ea01aa9a596a2cc7c054913fe46b892. Exact validated tree: 3524dfa. Connector publication controls remote author metadata. No npm release or compatibility-floor change.
Pin Next and its matching env/SWC cohort to16.3.8 to resolve six current docs-site advisories. Preserve unrelated dependencies and compatibility floors. Validated by Codex in the independent cloud: frozen install, full and production official audits, docs build/type-check, cohort tests and governance. Existing ignored Vue2 low finding remains explicit. Local validated commit accf4a6e01a818bb75de1d43666ca30b76c2a09c; exact tree285cc92f0dc18b7aa5abc7ab10fce451a8ca616b. Connector controls remote author metadata.
The actual Chromium font-table gate reproduced zero-height vertical glyphs from WenQuanYi. Install the reviewed Noto CJK prerequisite and retain its physical font cohort as evidence; keep all glyph bounds and advance assertions unchanged. Local workflow formatting/governance passed. Original failed pixels and geometry retained from run37718395780. Local commit249c3700c91b71693b0e8b9a70c1658e4aaa715f; exact tree320792ed4bcbfbf09ea9992d76b61cbb605a9679. No renderer/runtime source change.
Selectively adapt PR #326 without importing its historical dependency or Markdown implementation. Preserve BOM/UTF-16/strict UTF-8 auto precedence and the default GB18030 fallback; expose six explicit single-byte labels and text.fallbackEncoding throughout current text rendering, including LRC. Use single-byte offsets for virtual line segments and search. Add charset, public type, precedence, exact-offset and real-browser regression gates to the standard test chain, retaining browser artifacts in Public CI. Validated locally: 53 focused tests, 35 text package tests, core and all 34 renderer builds/type-checks, governance, docs, browser fixtures and bundle. Chromium/WebKit execution is pending on GitHub-hosted CI; local browser launch was not attempted. No dependency, release or compatibility-floor change. Co-authored-by: 4gray <fourgray@proton.me> Prepared as local commit 1809ec12042523f0c7158263c6dab39150ab01c5; published through the authorized connector with identical tree ecabf9c.
wybaby168
changed the title
Document the application-owned dependency overrides, current default versus constrained audit results, existing transitive Node requirement, CLI Full selection and workspace license-snapshot boundary. Link both installation guides to the shipped policy. Six Markdown files only; runtime, package dependencies, engines and workflows are unchanged. Validation: JSON examples and links, release facts, 114-page documentation production build, and final wording diff checks. Prepared and reviewed from local Codex commit 892b058791a0c3493d763e85c8550c1793985f19; remote tree is identical.
Add isolated packed DICOM browser evidence with contamination controls and repair transactional preparation for an ordinary versioned DOCX dependency. Preserve rendering assertions and verify registry package integrity after migration. Locally validated source tree: 0fe8d63 Local source commit: 303dfe3d780e8e1beb10af78feef4ec4726c6ecf
Keep the exact measurement that satisfied the rendering poll and independently enforce the retained report thresholds. Add negative controls for an intervening blank read and blank retained evidence while preserving the original hosted discrepancy. Validated source tree: b506193 Local source commit: cd3fcf5cdd7f97d609064738b9dbf0195ce508d4
Use ordinary published DOCX 0.3.34 and remove its transitional patch. Bundle DICOM and Mermaid runtime inputs with exact license and file identities; verify cold installed consumers, rendered screenshots, compressed DICOM syntaxes, visible mathematics, and cleanup in Chromium and WebKit. Retain the complete Full renderer set while using exact-version CAD and drawing asset dependencies to meet the CDN unpacked-size limit. Validate complete offline copying and actual DWG/Draw.io rendering. Add independent Linux browser evidence gates and project all licensed DICOM test fixtures. This is a source review candidate. Aggregate versions remain unfrozen, Linux validation is pending, and the traditional PPT publisher binding is unresolved. Source commit: 8d6531781b5d193c84fd94008bc462a755346f44
wybaby168
changed the title
Schedule renderer and capability workspaces together through pnpm's dependency order instead of building all renderers before capabilities. A clean drawing build now waits for the Mermaid engine and its declarations. Remove the redundant later capability batch from the root build. Validation: a fresh isolated checkout with independent frozen dependencies and empty affected dist/build-info directories passed the normal root build and standalone type checks. Text completed before Mermaid, and Mermaid completed before drawing started. All 17 DICOM and 104 Mermaid output files match the passed browser evidence byte-for-byte; 11 projection checks and two clean-build contracts passed. Source commit: 7f6e90984f04b76aa95af92b5c6e4f72440064f3
Integrate the five verified constituent squash merges. Preserve the ordinary published DOCX dependency guard and the complete offline asset distribution rules. The resolved tree is identical to the previously verified candidate.
wybaby168
marked this pull request as ready for review
October 9, 2026 08:48
This was referenced Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restored renderer fixes depended on transitional DOCX packaging, and Web Full exceeded jsDelivr's 150 MB unpacked limit. This candidate adopts the published DOCX engine, verifies ordinary browser runtime dependencies, and retains every Full renderer while moving heavy offline assets into matching dependency packs.
@file-viewer/docx@0.3.34and remove the active DOCX patch and repackaging helper. Verify identical DOCX bytes across all three delivery surfaces.Public head:
9d56e9737b84bd3c88674b97dac730b0bc009c8c; tree:439b912825445278b0b091a04ada760853af757b. This normal merge integrates maine8a2cf9581e942cf31a9b32b3791e646d6fdc579after #313, #348, #349, #346 and #347 were squash merged. Its file tree is identical to the previous verified candidate18c12a899372140eba38c2bf8950827b294c889b. The official source projection again verified 5,297 source objects and 290 transformed outputs without missing, mismatched or forbidden files.Related issue
Refs #311, #326, #329, #338, #340, #341, #346, #347, #348, #349 and #351. Traditional PPT ownership and publication remain a separate release gate.
Change classification
Verification
pnpm build:renderer-packagespnpm type-check:corenode packages/renderers/dicom/scripts/verify-packed-browser.mjsnode packages/capabilities/mermaid/scripts/verify-packed-browser.mjspnpm --filter @file-viewer/web-full verify:packed-assetsThe independent Linux cold-browser job passed for the current head. Its GitHub merge commit
eab601b062fc3096189617796c91ed7301585261has maine8a2cf9581e942cf31a9b32b3791e646d6fdc579and this PR head as parents, with the same tree as the PR. All 22 retained DICOM PNG records were independently checked for byte/hash identity and visible center-image content. The current artifact ZIP matches GitHub digestf51a2c55979770f362b2ba181295e3ffa0571db4e4fc8474475fa7004f1f4291.The current-head pipeline passed both jobs, including source build, type-check, issue regressions, real cold consumers and browser gates. Security and Geo3D also passed. After the normal base merge, the local Web build, 31 Node contracts and 14 Vitest consumer contracts passed. This source candidate is being prepared for review; the formal readiness helper rechecks all current-head gates, and exact-head landing authorization remains required. Aggregate version freeze, traditional PPT publication and registry release verification remain separate release gates.
Sample / fixture evidence
apps/viewer-demo/public/example/ct-small.dcm; licensed compressed/multiframe fixtures:test/fixtures/dicom/.apps/viewer-demo/public/example/sample.dwgandapps/viewer-demo/public/example/process.drawio.Visual evidence
Current Linux WebKit CT:
Current Linux WebKit mathematics in Markdown and drawing:
The earlier blank WebKit CT capture is rejected by the new PNG-content gate. Earlier screenshots remain historical coverage for preceding fixes.
Risk and compatibility
Checklist