Add optional ignoreIfNotRegistered to unregister #420 - #424
Closed
AzazelSensei wants to merge 1 commit into
Closed
AzazelSensei wants to merge 1 commit into
AzazelSensei wants to merge 1 commit into
Conversation
Default still throws when the type or instance is missing. Pass ignoreIfNotRegistered: true if a second dispose should no-op.
Author
|
This has been ignored long enough. Closing. Maybe put a note on the README if PRs aren't welcome. |
escamoteur
added a commit
that referenced
this pull request
Sep 19, 2026
- skipUnregisterIfNotRegistered: global flag mirroring skipDoubleRegistration (#420, #424) - ObjectRegistration.acceptsParams; passing params to a registration without a param factory now fails an assert instead of being ignored - CONTRIBUTING.md adapted from #426; ship only get-it-expert skill; untrack pubspec.lock
Member
|
You were right to be annoyed, sorry — the repo simply wasn't looked after for a while, which is not how PRs should be treated. We went with a slightly different shape in 9.3.0: a global flag |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Widget dispose can run twice.
unregisterstill throws by default so that still shows a double-dispose, but you can passignoreIfNotRegistered: trueif the second call should just no-op.Fixes #420