feat(flow-php/symfony-telemetry-bundle): honour upstream trace sampling decision - #2582
Merged
Conversation
…ng decision - default sampler is now parent_based, matching the OTel SDK - configurable parent_based root sampler - new http_kernel require_trace_context flag, HTTP-scoped - messenger sync transport no longer lifts request suppression
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## 1.x #2582 +/- ##
============================================
+ Coverage 86.27% 86.29% +0.01%
- Complexity 23237 23666 +429
============================================
Files 1816 1816
Lines 71840 71870 +30
============================================
+ Hits 61981 62020 +39
+ Misses 9859 9850 -9 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Log
Added
flow-php/symfony-telemetry-bundle- configurablesampler.rootfor theparent_basedsamplerflow-php/symfony-telemetry-bundle-instrumentation.http_kernel.require_trace_contextto trace only requests arriving with a trace contextFixed
flow-php/symfony-telemetry-bundle- messenger sync transport no longer lifts request tracing suppressionflow-php/telemetry-otlp-bridge-otlp_tracer_provider()no longer overrides the parent-based sampling defaultChanged
flow-php/telemetry- default sampler is nowParentBasedSampler(AlwaysOnSampler), matching the OpenTelemetry SDKflow-php/symfony-telemetry-bundle- defaultsampler.typeis nowparent_basedRemoved
Deprecated
Security