fix(fleetops): address geofence history by public id - #44
Merged
Conversation
The request sent {{driver_uuid}} — a variable nothing set, and an identifier the
public API does not issue in the first place. It was the only place in the
collection asking for an internal id.
The endpoint now resolves the driver by public_id
(fleetbase/fleetops@c499bce0), so this sends {{driver_id}}, which Create a Driver
already captures. The path variable is renamed to match.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The request sent
{{driver_uuid}}— a variable nothing set, and an identifier the public API does not issue in the first place. It was the only place in the collection asking for an internal id, which is how the variable sweep surfaced it.The endpoint now resolves the driver by
public_id(fleetbase/fleetops@c499bce0), so this sends{{driver_id}}, whichCreate a Driveralready captures. The path variable is renamed from:driverUuidto:driverIdto match.Without this the request answers
404 Driver resource not found.— the API fix landed first, so the collection is currently the half that is wrong.🤖 Generated with Claude Code