Skip to content

feat(alerts): Add memory utilization rules - #112

Merged
nfebe merged 2 commits into
mainfrom
feat/container-memory-utilization
Aug 25, 2026
Merged

feat(alerts): Add memory utilization rules#112
nfebe merged 2 commits into
mainfrom
feat/container-memory-utilization

Conversation

@nfebe

@nfebe nfebe commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Add container memory utilization to alert rules and dashboards while keeping raw memory usage available in bytes.

@sourceant

sourceant Bot commented Aug 25, 2026

Copy link
Copy Markdown

Code Review Summary

This PR adds container memory utilization metrics to alert rules and dashboards. The changes include UI updates for clarity, such as metric-specific hints and explicit unit labels, along with corresponding unit handling in dashboard panels and a regression test.

🚀 Key Improvements

  • Introduced container.memory.utilization metric support.
  • Added a hint property to metric options in AlertRulesPanel.vue for better user guidance.
  • Updated labels to clearly distinguish between raw memory usage and percentage-based utilization.
  • Ensured correct unit rendering in dashboard PanelCard components.

💡 Minor Suggestions

  • In the future, consider using the METRIC constant in PanelCard.vue and PanelEditorModal.vue instead of hardcoded strings to ensure consistency with AlertRulesPanel.vue.

@sourceant sourceant Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review complete. No specific code suggestions were generated. See the overview comment for a summary.

@nfebe
nfebe merged commit 2980864 into main Aug 25, 2026
5 checks passed
@nfebe
nfebe deleted the feat/container-memory-utilization branch August 25, 2026 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant