Skip to content

feat: Fix multi-service deployment setup - #219

Merged
nfebe merged 1 commit into
mainfrom
fix/first-deployment-findings
Aug 23, 2026
Merged

feat: Fix multi-service deployment setup#219
nfebe merged 1 commit into
mainfrom
fix/first-deployment-findings

Conversation

@nfebe

@nfebe nfebe commented Aug 23, 2026

Copy link
Copy Markdown
Contributor

Make first deployments work for ordinary multi-service stacks without manual host access. Failed operations now return useful outcomes. They no longer leave deployments locked or partially configured.

@sourceant

sourceant Bot commented Aug 23, 2026

Copy link
Copy Markdown

Code Review Summary

This PR significantly improves deployment reliability and security, particularly for multi-service stacks. It introduces better environment variable management, reliable domain transitions with rollbacks, enhanced database provisioning for PostgreSQL, and robust bind mount ownership handling with security guards against symlink attacks.

🚀 Key Improvements

  • Migration to .env as the principal environment file with full backward compatibility for .env.flatrun.
  • Atomic domain operations with rollback logic to prevent orphaned metadata or partial configurations on failure.
  • Improved PostgreSQL support where provisioned users are granted proper ownership of the public schema, allowing table creation without manual host access.
  • Introduction of one-shot service jobs and standardized timeouts for deployment actions to prevent indefinite blocking.
  • Enhanced security for bind mounts through path validation and symlink traversal checks during ownership updates.
  • Expanded OpenAPI metadata including x-plan-supported markers and enum values for database and action configurations.

💡 Minor Suggestions

  • The normalization of database types (postgres vs postgresql) is slightly divergent between the API layer and the database manager. While handled correctly at the boundaries, consolidating this into a shared package could improve consistency.

@sourceant sourceant Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review complete. No specific code suggestions were generated. See the overview comment for a summary.

First deployments preserve bind mount ownership and create usable databases.
Routed services join the proxy and certificate failures restore prior configuration.
Compose environment changes remain consistent across validation and deployment.

Jobs report container outcomes and time out instead of locking later operations.
@nfebe
nfebe force-pushed the fix/first-deployment-findings branch from f940354 to 3f870c6 Compare August 23, 2026 21:46
@nfebe nfebe changed the title feat: Improve first deployment reliability feat: Fix multi-service deployment setup Aug 23, 2026
@nfebe
nfebe merged commit 4ffa8ae into main Aug 23, 2026
6 checks passed
@nfebe
nfebe deleted the fix/first-deployment-findings branch August 23, 2026 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant