feat: Fix multi-service deployment setup - #219
Merged
Merged
Conversation
Code Review SummaryThis PR significantly improves deployment reliability and security, particularly for multi-service stacks. It introduces better environment variable management, reliable domain transitions with rollbacks, enhanced database provisioning for PostgreSQL, and robust bind mount ownership handling with security guards against symlink attacks. 🚀 Key Improvements
💡 Minor Suggestions
|
First deployments preserve bind mount ownership and create usable databases. Routed services join the proxy and certificate failures restore prior configuration. Compose environment changes remain consistent across validation and deployment. Jobs report container outcomes and time out instead of locking later operations.
nfebe
force-pushed
the
fix/first-deployment-findings
branch
from
August 23, 2026 21:46
f940354 to
3f870c6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make first deployments work for ordinary multi-service stacks without manual host access. Failed operations now return useful outcomes. They no longer leave deployments locked or partially configured.