Repository navigation
feat(calendar): resolved days, range delete; list tables keep rows beside extra fields - #228
Merged
Merged
Conversation
…side extra fields
Bump go-flashduty to v0.15.17 and regenerate:
- calendar event-list returns days (resolved state per date).
- calendar event-delete clears a date range with --start-at/--end-at;
<cal-id> may be positional (--cal-id still works), --event-id optional.
- calendar event-upsert --summary is optional.
- schedule fixed-time notify week/month cycles, license list
release_limited, work item status docs.
A list envelope with fields beyond pagination metadata (event-list's
days, license list's release_limited, work item list's
idempotent_replay) used to render as a flattened key/value dump. When
the rows field is items/docs/list, the table now prints the rows and
names the other fields ("Also in the response: days (use --json to see
it)."). HasMore counts as pagination metadata. cligen describes such
responses as {items: [...], <siblings>} page wrappers.
Calendar card: how to read days, range reset, positional cal-id.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
SDK v0.15.17 (regenerated with
cligen+make gen-cards)calendar event-list: response carriesdays— the resolved state of every date in scope (is_off,event_id,layer).calendar event-delete:--start-at/--end-atclear the calendar's own events off a date range;--event-idis optional;<cal-id>can be positional and--cal-idkeeps working.calendar event-upsert:--summaryis optional.week/monthcycles +--days, license listrelease_limited, work item status docs.List tables with extra fields
listEnvelope(runtime) only treated{items, total, …pagination}as a list, so a response with any other field beside the rows printed as a flattened FIELD/VALUE dump — for a year ofevent-listthat is ~1,000 lines ofDAYS.2026-…keys. Now, when the rows field isItems/Docs/List, the table prints the rows as before and names the rest:Detail objects whose nested slice has another name stay vertical (
TestGenericListPage_NestedRowsInDetailObject).HasMoreis now pagination metadata. Affected today: calendar event-list, license list, work item list / post-mortem bind.--json/toon output is unchanged; output bounding (listEnvelopeKey) stays scalar-siblings-only on purpose, since a year'sdaysmap alone exceeds the 16 KB limit and cannot be shortened.cligen's
listEnvelopeaccepts object/array siblings the same way, so help and cards describe event-list as{items: [...], days, total}.Card:
calendar.mdexplains readingdays(layer order), range reset, positional<cal-id>.Checks
go test ./...— all packages pass (new:TestRenderGenericTable_EnvelopeWithSiblings,…EmptyEnvelopeWithSiblings,TestGenericListPage_NestedRowsInDetailObject,…HasMoreIsMetadata, cligenTestListEnvelope)make check-cards— OKevent-delete --cal-id X --event-id Ysends{"cal_id","event_id"};event-delete X --start-at … --end-at …sends the range.