Repository navigation
feat: bump go-flashduty to v0.15.15 (alert event list requires a time window) - #224
Merged
Merged
Conversation
The alert event list endpoint requires a time range of at most 31 days, as the alert list command already states.
The alert event list endpoint now requires start_time and end_time with a span of at most 31 days. The SDK types them as int64, so alert-event list passes the parsed --since/--until window as plain values; it already always sent a window (default --since 1h --until now). Regenerated commands and cards pick up the other contract updates in the SDK release: --start-time/--end-time are required on the generated alert event list command; integration create/update gain --integration-key and --is-test; dashboard queries resolve gains --max-data-points and --preserve-builtin-variables; investigation targets document purpose and an optional query datasource_id; incident feed and integration response help reflect the typed fields.
This was referenced Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bump go-flashduty to v0.15.15. In that SDK version,
POST /alert-event/listrequiresstart_timeandend_time, and the span must not exceed 31 days.alert-event listpasses the parsed--since/--untilwindow as plainint64values. The SDK now types both fields asint64; before, they were*int64. The command already sent a window on every call (default--since 1h --until now), so its behavior does not change.alert-event listhelp now states the 31-day window limit, using the same wording asalert list(cherry-picked from docs(cli): note the 31-day window limit in alert-event list help #218).go run ./internal/cmd/cligen) and cards (make gen-cards):--start-time/--end-timeare now required--integration-key,--is-test; integration update:--is-test--max-data-points,--preserve-builtin-variables(monit card fence updated)purposeand marks the querydatasource_idas optionalVerification
make check: fmt with no diff, golangci-lint 0 issues,go test -race ./...passes, build passesmake check-cards:skilldoc: cards OK