feat: Add optional Prometheus metrics endpoint - #24
Draft
MoeMahhouk wants to merge 2 commits into
Draft
Conversation
New -metrics-addr flag (env METRICS_ADDR, empty = disabled) serves
/metrics on a separate listener. Records syncproxy_forwards_total
{method,backend,result} where success means the backend answered 2xx
(i.e. the EL demonstrably received and accepted the forwarded call,
including in mirror mode where the caller only gets an empty ACK), and
a forward duration histogram.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
New
-metrics-addrflag (envMETRICS_ADDR, empty = disabled) serving/metricson a separate listener. Exposessyncproxy_forwards_total{method,backend,result}— wheresuccessmeans the backend answered 2xx (the EL demonstrably received and accepted the forwarded call, also in mirror mode),http_errora non-2xx answer, anderrora transport failure or timeout — plus asyncproxy_forward_duration_secondshistogram. Addsprometheus/client_golangv1.23.2 (latest compatible with the repo's Go 1.24 pin).⛱ Motivation and Context
Lets operators alert on "is the backend EL actually receiving engine calls", which is otherwise invisible in mirror mode since callers only get an empty ACK.
📚 References
Stacked on #22
✅ I have run these commands
make lintmake test-racego mod tidyCONTRIBUTING.md