Skip to content

fix(key-link): validate page size before requests - #56

Open
arunimshukla wants to merge 1 commit into
fireblocks:mainfrom
arunimshukla:fix/key-link-page-size-validation
Open

arunimshukla wants to merge 1 commit into
fireblocks:mainfrom
arunimshukla:fix/key-link-page-size-validation

Conversation

@arunimshukla

Copy link
Copy Markdown

Summary

  • parse Key Link page sizes as integers
  • enforce the API-supported 1-50 range for signing and validation key listings
  • add end-to-end coverage for the upper boundary and client-side rejection

Why

The CLI currently accepts any string for --page-size, so unsupported values are sent to the API and fail with a generic 400 response. Validating the documented range locally gives users an immediate, actionable error and keeps the two Key Link list commands consistent.

Testing

  • npm test -- --runInBand (86 tests passing)
  • npm run build

Fixes #54

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Adding paging argument results in bad request status

1 participant