Repository navigation
Conversation
Fix for using shouldUpgradeAnonymous for Apple provider
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
yoman07
changed the title
|
Hello 👋, this PR has been opened for more than 2 months with no activity on it. If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing! You have 15 days until this gets closed automatically |
russellwheatley
added
auth
Keep Open
|
bump |
1 similar comment
|
bump |
|
Thanks @yoman07 for this, and sorry it sat for so long. We've split it up so each half could land on its own: Apple anonymous upgrade: your fix is in #730, cherry-picked with your authorship preserved. It also guards the no-user and null-credential cases and adds tests. That's part of #253; the remaining piece, handling credential-already-in-use when the account already exists, is tracked in #734. flutter_facebook_auth 7 (tokenString): already on main via #553. Closing this in favour of those. Thanks again! |
…dential (#730) * fix(ui_oauth_apple): upgrade anonymous users by linking the Apple credential Apple sign in ignored shouldUpgradeAnonymous and always called signInWithProvider, so an anonymous user's uid and data were lost. Link instead, matching the other providers. Split out of #288. Fixes #253. * fix(ui_oauth_apple): report an error instead of hanging when there is nothing to link AuthAction.link with no signed in user null-shorted, and a null credential from linkWithProvider was force unwrapped inside .then. Both left the flow stuck loading. Report them through the listener, matching TwitterProvider, and cover anonymous upgrade and the no-user case in tests. --------- Co-authored-by: Roman Barzyczak <roman.barzyczak+web@gmail.com>
Fix for using shouldUpgradeAnonymous for Apple provider
Description
It fixes problem with updating anonymous account for apple provider.
Related Issues
Problem well described here:
Apple log in inconsistency problem
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process. Updating the
pubspec.yamland changelogs is not required.///).melos run analyze) does not report any problems on my PR.melos run test:unit:alldoesn't fail).Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?