Skip to content

Stop granting id-token to the shared release workflow - #19

Merged
soodoku merged 1 commit into
mainfrom
fleet/drop-release-id-token
Oct 24, 2026
Merged

soodoku merged 1 commit into
mainfrom
fleet/drop-release-id-token

Conversation

@soodoku

@soodoku soodoku commented Oct 24, 2026

Copy link
Copy Markdown
Contributor

py-canon's reusable release workflow no longer has a job that requests an OIDC token (gojiplus/py-canon#118), so the release job's id-token: write grant does nothing. This removes it. The publish job, which does the PyPI upload, keeps its own grant.

🤖 Generated with Claude Code

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review 🔄 Running since 2026-10-24T02:42:00.287590Z 13c6180 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

py-canon's reusable release no longer requests an OIDC token (py-canon#118).
The publish job keeps its own id-token grant.

Also updates packages flagged by new security advisories in uv.lock.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@soodoku
soodoku force-pushed the fleet/drop-release-id-token branch from 2958b4e to 6e546c5 Compare October 24, 2026 03:20
@soodoku
soodoku merged commit bb117fe into main Oct 24, 2026
12 checks passed
@soodoku
soodoku deleted the fleet/drop-release-id-token branch October 24, 2026 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant