Skip to content

docs: fix broken links in readme - #296

Merged
JuroUhlar merged 1 commit into
mainfrom
docs/fix-broken-links
Oct 9, 2026
Merged

JuroUhlar merged 1 commit into
mainfrom
docs/fix-broken-links

Conversation

@JuroUhlar

Copy link
Copy Markdown
Collaborator

Fixes two broken links in readme.md reported by the link checker.

  • Node LTS releases: https://nodejs.dev/en/about/releases/ -> https://nodejs.org/en/about/previous-releases (nodejs.dev is dead)
  • Secret API key: https://dev.fingerprint.com/docs/quick-start-guide#4-get-smart-signals-to-your-server -> https://docs.fingerprint.com/docs/node-server-quickstart#1-get-your-secret-api-key (the old anchor no longer exists; the Node quickstart has a matching "Get your secret API key" section)

Both new URLs return 200 and the anchor exists on the rendered page. No changeset, as this is a docs-only change.

@changeset-bot

changeset-bot Bot commented Oct 9, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 84f9c7f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions

github-actions Bot commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

⚠️ This PR doesn't contain any changesets. If there are user-facing changes, don't forget to run:

pnpm exec changeset

to create a changeset.

@github-actions

github-actions Bot commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

Coverage report

St.❔
Category Percentage Covered / Total
🟢 Statements 98.25% 168/171
🟢 Branches 97.03% 98/101
🟢 Functions 100% 37/37
🟢 Lines 98.21% 165/168

Test suite run success

132 tests passing in 30 suites.

Report generated by 🧪jest coverage report action from 84f9c7f

Show full coverage report
St File % Stmts % Branch % Funcs % Lines Uncovered Line #s
🟢 All files 98.24 97.02 100 98.21
🟢  src 98.54 98.76 100 98.51
🔴   ...edApiTypes.ts 0 0 0 0
🔴   index.ts 0 0 0 0
🟢   sealedResults.ts 100 100 100 100
🟢   ...rApiClient.ts 96.15 97.22 100 96.15 360,364
🟢   types.ts 100 100 100 100
🟢   urlUtils.ts 100 100 100 100
🟢   webhook.ts 100 100 100 100
🟢  src/errors 97.05 90 100 96.96
🟢   apiErrors.ts 100 100 100 100
🟢   ...orResponse.ts 100 100 100 100
🟢   toError.ts 87.5 88.88 100 87.5 21
🟢   unsealError.ts 100 50 100 100 14

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The documentation-only changes directly replace both broken links with appropriate destinations.

0 open findings

What changed in this PR

Updates two outdated documentation links in the README.

Changes:

  • Replaces the defunct Node.js releases URL.
  • Links the Secret API key text to the matching Node quickstart section.
File Description
readme.md Fixes two broken external documentation links.

🧠 Review effort: Balanced


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@JuroUhlar
JuroUhlar marked this pull request as ready for review October 9, 2026 14:22
@JuroUhlar
JuroUhlar merged commit 3b1acec into main Oct 9, 2026
20 checks passed
@JuroUhlar
JuroUhlar deleted the docs/fix-broken-links branch October 9, 2026 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants