fix: correct named unary arithmetic precedence - #1309
Merged
Conversation
Parse the operand of scalar, values, keys, and each at the named-unary boundary so arithmetic binds inside it. This restores the expected grouping of ! scalar @array % 2 used by Class::MakeMethods. Generated with [Codex](https://openai.com/codex/) Co-Authored-By: Codex <codex@openai.com>
Restrict scalar's relaxed arithmetic operand boundary to scalar. keys, values, and each keep their aggregate operand boundary, restoring expressions such as keys(%hash) * 4 used by perf/benchmarks.t. Generated with [Codex](https://openai.com/codex/) Co-Authored-By: Codex <codex@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scalaroperands at the named-unary precedence boundary, restoring the documented behavior of! scalar @array % 2.keys,values, andeach; this fixes UAT’skeys(%benchmarks) * 4compile regression.Fixes #1259
Validation
prove src/test/resources/unit/precedence.t(system Perl, 18 tests)./jperl src/test/resources/unit/precedence.t(18 tests)./jperl --interpreter src/test/resources/unit/precedence.t(18 tests)cd perl5_t/t && ../../jperl perf/benchmarks.t(6,648 checks)makeafter the UAT regression correction49e8abb00Generated with Codex