Migrate Form components using Formisch and Valibot - #65
Merged
Conversation
Add Formisch for SolidJS and its Valibot peer dependency to the web package. I limited this commit to dependency installation; Codex applied the manifest and lockfile changes and ran the web TypeScript check successfully. Assisted-by: Codex:gpt-5.6-sol
Replace manual form parsing with a Valibot schema and Formisch-managed field validation while preserving the existing Relay mutation and response handling. I asked Codex to plan and implement the sign-in migration. Codex added schema validation and accessible field errors, preserved the Relay variable and callback behavior, and verified the result with Oxfmt, Oxlint, the web TypeScript check, and a production web build. Assisted-by: Codex:gpt-5.6-sol
Style error notices in red, success notices in green, and warning notices in orange across light and dark themes. Apply the error treatment to invalid sign-in fields and their inline validation messages. I asked Codex to make login failure, success, and warning states visually distinct. Codex added semantic theme tokens and matching notice, input, focus, and field-error styles, then verified the changes with formatting, linting, TypeScript, and a production web build. Assisted-by: Codex:gpt-5.6-sol
Manage the generated slug with Formisch and Valibot while preserving Relay mutation handling. Keep the submit button inside the form and associate the read-only hint and validation error with the slug field. I chose to migrate the read-only form for consistency with sign-in. Codex reviewed the migration and accessibility feedback, identified the required form and description associations, formatted the file, and verified it with Oxlint and the web TypeScript check. Assisted-by: Codex:gpt-5.6-sol
Match the database slug rules in the Valibot schema by requiring 4 to 63 lowercase letters, digits, or hyphens. Normalize generated Faker slugs to lowercase before validation. I asked Codex to align client-side slug validation with the database constraints. Codex implemented the Valibot rules, found and corrected uppercase Faker output, and verified the change with formatting, linting, TypeScript, a production web build, and 100,000 generated slug samples. Assisted-by: Codex:gpt-5.6-sol
Combine Formisch validation with Kobalte controls and CSS module styling, removing accidentally committed merge markers while preserving Relay mutation feedback. Also apply the repository formatter to the previously resolved instance form. Codex reconciled the conflicting form implementations at the user's request. Oxfmt, the web TypeScript check, and git diff --check passed; the full commit hook remained blocked by unrelated existing GraphQL/model type errors. Assisted-by: Codex:gpt-5.6-sol
Move invalid-input and semantic notice styling into the CSS module used by the forms, and remove the unused duplicate global stylesheet. Codex applied the review feedback at the user's request and verified the result with mise run check, mise run build, and git diff --check. Assisted-by: Codex:gpt-5.6-sol
Member
Author
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7d64794419
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
sij411
marked this pull request as ready for review
September 7, 2026 07:37
dodok8
requested changes
Sep 7, 2026
Generate each noun with a 1–20 character bound so the three-word instance slug remains within the schema's 4–63 character limit. Codex implemented the pull-request review feedback at the user's request. The change was verified with mise run check and by validating 10,000 generated slugs against the schema constraints. Assisted-by: Codex:gpt-5.6-sol
2chanhaeng
previously approved these changes
Sep 8, 2026
dodok8
previously approved these changes
Sep 8, 2026
dahlia
requested changes
Sep 8, 2026
dahlia
left a comment
dahlia
left a comment
Member
There was a problem hiding this comment.
It would be great if agent skills for Formisch and Valibot are also installed in the repository.
Member
Author
Installed: 7a41d52 |
dahlia
approved these changes
Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrated forms with Formisch and Valibot.