ci: run the checks on pull requests - #7
Open
faustienf wants to merge 2 commits into
Open
Conversation
Nothing verified a change before it was merged. The checks lived in the git hooks, which --no-verify skips, and in the release workflow, which only runs once a version has already been tagged — PRs #1 through #6 all merged without a single automated check. The workflow runs type checking, the test suite with coverage, the build (which carries publint and are-the-types-wrong) and the example's type check, on Node 22 and 24. Older Node is not testable here: tsdown needs ^22.18.0 || >=24.11.0 and jsdom needs ^22.22.2 || ^24.15.0 || >=26.0.0, well above the engines floor of 18. That floor is about importing the published bundle — browser code with no Node API in it — which this suite would not exercise anyway. Coverage was already wired up as a dependency but never actually run: nothing invoked @vitest/coverage-v8 and there was no vitest config. It reports 100% on every metric, so the threshold is set there — new code arrives with tests or the run goes red. The text reporter is swapped for text-summary because it renders an empty file table on vitest 4.1.10 while the data behind it is correct. With CI covering this, the slower half of pre-commit moves to pre-push, so committing stays quick and nothing reaches the remote unvalidated. Dependabot watches the actions and the devDependencies monthly, grouped into one pull request.
It shipped while the changelog was being rewritten and never got an entry. The release carries no library change at all — only the move to publishing from CI — so the section says that rather than inventing user-facing notes.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nothing verified a change before it was merged. The checks lived in the git hooks, which
--no-verifyskips, and in the release workflow, which only runs once a version has already been tagged — PRs #1 through #6 all merged without a single automated check.CI runs type checking, the test suite with coverage, the build (which carries publint and are-the-types-wrong) and the example's type check, on Node 22 and 24. Older Node is not testable here: tsdown needs
^22.18.0 || >=24.11.0and jsdom needs^22.22.2 || ^24.15.0 || >=26.0.0, both well above theenginesfloor of 18. That floor is about importing the published bundle — browser code with no Node API in it — which this suite would not exercise anyway.Coverage was already a dependency but never actually run: nothing invoked
@vitest/coverage-v8and there was no vitest config. It reports 100% on every metric, so the threshold is set there — new code arrives with tests or the run goes red. Thetextreporter is swapped fortext-summary: on vitest 4.1.10 it renders an empty file table even though the data behind it is correct (coverage-final.jsonand the HTML report both list the file).Hooks: with CI covering this, the slower half of pre-commit moves to pre-push. Committing stays quick, and nothing reaches the remote without the publishable package being validated.
Dependabot watches the actions and the devDependencies monthly, grouped into one pull request.
Also records 1.2.1 in the changelog — it shipped during the changelog rewrite and never got an entry.
🤖 Generated with Claude Code