Conversation
This is a noop because O_RW is 0 but O_NORW is the correct constant to open a file without read/write permissions.
The query array gained a third entry in dd30c82 but numQueries stayed at 2, so `size =` was never queried and every Alacritty user silently got the hardcoded 11.25 fallback.
This reverts commit 8b8efcd.
Contributor
There was a problem hiding this comment.
Pull request overview
Release prep for v2.67.1, combining build-system updates and multiple cross-platform detection fixes (macOS / Windows / Android / Haiku), plus a few internal cleanups.
Changes:
- Bump version to 2.67.1 and update release notes / packaging templates.
- Fix and improve platform detections (terminal theme defaults, macOS preferences-backed detectors, Android codenames, Windows locale env handling, Haiku loadavg).
- Introduce/extend build configuration checks and compatibility workarounds (C23 checks, Haiku getloadavg probing, Apple codec weak import guard).
Reviewed changes
Copilot reviewed 23 out of 24 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/options/display.c | Move light-theme detection into display option init to set better color defaults. |
| src/logo/image/image.c | Enable image logo support in Zellij by relaxing multiplexer detection. |
| src/fastfetch.h | Remove terminalLightTheme from global state. |
| src/detection/wmtheme/wmtheme_apple.m | Remove Obj-C implementation (migrating away from raw plist reads). |
| src/detection/wmtheme/wmtheme_apple.c | Reimplement wm theme detection via CFPreferences for cache consistency. |
| src/detection/wallpaper/wallpaper_apple.m | Prefer AppKit API for reliable static wallpaper path retrieval. |
| src/detection/terminalfont/terminalfont.c | Fix Alacritty TOML parsing and Ghostty config/fallback handling. |
| src/detection/os/os_android.c | Provide real Android version codenames based on major release. |
| src/detection/locale/locale_windows.c | Prefer $LC_ALL / $LANG when available before Win32 locale APIs. |
| src/detection/loadavg/loadavg_sunos.c | Make loadavg include more portable via __has_include. |
| src/detection/cursor/cursor_apple.m | Remove Obj-C implementation (migrating away from raw plist reads). |
| src/detection/cursor/cursor_apple.c | Reimplement cursor detection via CFPreferences. |
| src/detection/codec/codec_apple.c | Avoid macOS 10.15 symbol issues using weak import + runtime pointer check. |
| src/detection/camera/camera_apple.m | Simplify external camera type selection using symbol address check. |
| src/common/windows/nt.h | Add LdrEnumerateLoadedModules declarations for module iteration. |
| src/common/library.h | Add public API for iterating loaded dynamic libraries. |
| src/common/impl/processing_windows.c | Pass a customized child environment to spawned processes on Windows. |
| src/common/impl/library.c | Implement dynamic library iteration per-platform (Win32/Apple/dl_iterate_phdr). |
| src/common/impl/init.c | Remove early terminal theme detection from global instance init. |
| README.md | Remove Star History section. |
| debian/changelog.tpl | Add new Debian changelog template entry for the updated release. |
| CMakeLists.txt | Bump version, add C23 checks/workarounds, and improve Haiku loadavg selection. |
| CHANGELOG.md | Add 2.67.1 release notes and fix assorted changelog wording/punctuation. |
| .gitignore | Ignore *.log files. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
1
to
5
| #include "detection/locale/locale.h" | ||
| #include "common/windows/unicode.h" | ||
|
|
||
| #include <windows.h> | ||
| #include <winnls.h> | ||
|
|
Comment on lines
+194
to
+199
| char path[PATH_MAX * 3]; | ||
| ULONG outBytes; | ||
| if (NT_SUCCESS(RtlUnicodeToUTF8N(path, sizeof(path), &outBytes, DataTableEntry->FullDllName.Buffer, (uint32_t) (DataTableEntry->FullDllName.Length + sizeof(wchar_t))))) { | ||
| struct LibraryIterateDynamicLibsBundle* bundle = (struct LibraryIterateDynamicLibsBundle*) Context; | ||
| *StopEnumeration = !bundle->callback(path, bundle->userData); | ||
| } |
Comment on lines
+62
to
+80
| wchar_t* result = malloc((sourceLength + 7) * sizeof(wchar_t)); | ||
| wchar_t* write = result; | ||
| bool foundLang = false; | ||
| for (const wchar_t* entry = source; *entry; entry += wcslen(entry) + 1) { | ||
| if (_wcsnicmp(entry, L"LANG=", 5) == 0) { | ||
| wcscpy(write, L"LANG=C"); | ||
| write += 6; | ||
| foundLang = true; | ||
| } else { | ||
| size_t entryLength = wcslen(entry) + 1; | ||
| memcpy(write, entry, entryLength * sizeof(wchar_t)); | ||
| write += entryLength; | ||
| } | ||
| } | ||
| if (!foundLang) { | ||
| wcscpy(write, L"LANG=C"); | ||
| write += 6; | ||
| } | ||
| *write = L'\0'; |
Comment on lines
+1
to
+5
| fastfetch (2.67.0~#UBUNTU_CODENAME#) #UBUNTU_CODENAME#; urgency=medium | ||
|
|
||
| * Update to 2.67.0 | ||
|
|
||
| -- Carter Li <zhangsongcui@live.cn> Thu, 06 Aug 2026 16:22:22 +0800 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist