Skip to content

fix(docs): match fake cursor to word slide animation on landing page - #1932

Open
Jta26 wants to merge 9 commits into
facebook:mainfrom
Jta26:main
Open

Jta26 wants to merge 9 commits into
facebook:mainfrom
Jta26:main

Conversation

@Jta26

@Jta26 Jta26 commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

What changed / motivation ?

The text-reveal animation on the home page is quite off. It has a large gap between the fake cursor and the word while transitioning words. This happened for me on all 3 major browsers.

Additional Context

Before

Screencast_20261004_211432.webm

After

Screencast_20261004_211652.webm

Screenshots, Tests, Anything Else

Pre-flight checklist

Jta26 and others added 5 commits October 4, 2026 20:02
The animated grid track and the container border interpolate on different curves, so the caret drawn on the container edge slid ahead of the clipped word. An invisible in-flow copy still sizes the grid, and the visible word is clipped to the container padding box where the border sits.
@vitejs/plugin-rsc excludes packages with a React peer from SSR dependency optimization. Keeping use-query-params in that include list as well makes esbuild reject the entry point and waku exits on startup.
@Jta26
Jta26 requested review from mellyeliu and nmn as code owners October 5, 2026 04:18
@vercel

vercel Bot commented Oct 5, 2026

Copy link
Copy Markdown

@Jta26 is attempting to deploy a commit to the Meta Open Source Team on Vercel.

A member of the Team first needs to authorize it.

@meta-cla

meta-cla Bot commented Oct 5, 2026

Copy link
Copy Markdown

Hi @Jta26!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 5, 2026
@meta-cla

meta-cla Bot commented Oct 5, 2026

Copy link
Copy Markdown

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

Jta26 added 2 commits October 4, 2026 21:45
A horizontal shorthand such as 10px 20px was serialized as 10px 20px / 10px because missing vertical corners copied only the first length.
Comment thread packages/style-value-parser/src/properties/__tests__/border-radius.test.js Outdated
Jta26 added 2 commits October 7, 2026 19:49
Pull request 1907 already covers the failing border-radius tests, so this docs change should not include it.
The pre-commit hook reformatted this expectation after the revert. Put the upstream lines back so this branch does not touch the file.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants