Created native memory manager to reduce nesting and simplify code - #25
Open
jshergal wants to merge 2 commits into
Open
Created native memory manager to reduce nesting and simplify code#25jshergal wants to merge 2 commits into
jshergal wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feel free to reject this PR, it was just something that I thought could be helpful by aiding in readability of the main Typst compiler C# code.
There are a couple of other cleanups in the PR, so if you like some, but aren't interested in the
NativeStringMemoryManagerobject, I can pull that stuff out and just add the others in.My changes started with just changing this line:
into this line:
I would imagine that a majority of the time, the
fontPathsvalue is going to come from either astring[]orList<string>, so it seemed like a good performance tweak to just check if theIEnumerable<string>is already one of those and only callToList()if it isn't.There are some other minor tweaks in the code as well, but the major change I added was the new
NativeStringManagerthat encompasses the marshaling calls, tracts each returned pointer, and then onDispose()frees them. The class itself doesn't add any real memory pressure, as it is using arrays from theArrayPool.Adding it allows for the removal of the try/finally blocks that are just dealing with that native memory. That reduces nesting within the code and removes some "boilerplate" noise.