Repository navigation
fix: correct macOS and Python compatibility checks - #2
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make the compatibility checks from #1 work with macOS editor launchers, aliased temporary paths, and the system Vim's embedded Python.
Fixes
/varand/private/varcan refer to the same directory, so comparing a resolved path against an unresolved path incorrectly failed successful installs.--cmdinside the editor. Homebrew's Vim launcher needsbasename,dirname, andreadlinkbefore Vim starts; clearing its process PATH prevented the missing-tool tests from reaching Vim.setup-pythonchangedLD_LIBRARY_PATH, causing Ubuntu's Vim to mix the hosted Python library with the system standard library. UltiSnips then failed withModuleNotFoundError: No module named 'math'.masterwhile feature branches are checked through their PRs to avoid duplicate matrices.Validation
git diff --check.