chore(deps): bump criterion from 0.5.1 to 0.8.2 - #1008
Conversation
dependabot
Bot
added
the
dependencies
LabelsThe following labels could not be found: Please fix the above issues or remove invalid values from |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
This PR changes mirrored Maestro source files in the public repo, but it does not link the matching private source-of-truth PR. Add one of these to the PR body, then re-run the check:
Mirrored files touched:
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9066c53a59
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| [dev-dependencies] | ||
| pretty_assertions = "1" | ||
| criterion = { version = "0.5", features = ["html_reports"] } | ||
| criterion = { version = "0.8", features = ["html_reports"] } |
There was a problem hiding this comment.
With Criterion 0.8 selected here, the existing bench files that import criterion::black_box (for example packages/tui-rs/benches/batch_bench.rs:5 and five others) start using a symbol Criterion 0.8 marks deprecated in favor of std::hint::black_box (docs.rs). The CI workflows I checked run cargo clippy --workspace --all-targets --locked -- -D warnings (.github/workflows/ci.yml:29 and .github/workflows/rust.yml:19); Cargo help describes --benches as checking bench targets and --all-targets as checking all targets, so these deprecation warnings become hard errors. Please update the bench imports/calls as part of this dependency bump.
Useful? React with 👍 / 👎.
Bumps [criterion](https://github.com/criterion-rs/criterion.rs) from 0.5.1 to 0.8.2. - [Release notes](https://github.com/criterion-rs/criterion.rs/releases) - [Changelog](https://github.com/criterion-rs/criterion.rs/blob/master/CHANGELOG.md) - [Commits](criterion-rs/criterion.rs@0.5.1...criterion-v0.8.2) --- updated-dependencies: - dependency-name: criterion dependency-version: 0.8.2 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
9066c53 to
cc80b4e
Compare
Bumps criterion from 0.5.1 to 0.8.2.
Release notes
Sourced from criterion's releases.
... (truncated)
Changelog
Sourced from criterion's changelog.
... (truncated)
Commits
7f0d745chore: release v0.8.24a467cechore(deps): bump crate-ci/typos from 1.40.0 to 1.43.0b277a75Fix panic with uniform iteration durations in benchmarks828af14fix: don't build alloca on unsupported targetsb01316bUpdate Readme4c02a3bExclude development scripts from published packagee4e06dfchore: release v0.8.1aa548b9fix: Homepage link950c3b7fix: Typo7e3e50cchore(deps): bump crate-ci/typos from 1.23.5 to 1.40.0