fix(geth-swap): support traefik v3 CRD api group - #234
Conversation
|
Change itself looks good — the One thing I spotted while reviewing: the same legacy API group shows up in - apiGroups: ["traefik.containo.us"]
resources: ["ingresses","ingressroutes"]
verbs: ["get", "list", "watch"]On Traefik v3 the IngressRoutes are in - apiGroups: ["traefik.containo.us", "traefik.io"]Happy either way — folded in here or as a follow-up. (Those two files are the only hits for the legacy group in the repo.) |
darkobas2
left a comment
There was a problem hiding this comment.
LGTM — the Capabilities.APIVersions.Has check with the legacy fallback is the right pattern here.
The beekeeper ClusterRole gap I raised in the comment above is being handled in a separate follow-up PR, so nothing to change here.
Traefik v3 (k3s >= 1.33) removed the legacy
traefik.containo.usAPI group,breaking geth-swap installs with
ingress.class: traefik:Pick
traefik.io/v1alpha1via cluster capabilities when available, falling backto the legacy group on older clusters. Backward compatible; chart bumped to 0.6.2.