Skip to content

fix(geth-swap): support traefik v3 CRD api group - #234

Merged
gacevicljubisa merged 2 commits into
masterfrom
fix/geth-swap-traefik-v3
Aug 12, 2026
Merged

fix(geth-swap): support traefik v3 CRD api group#234
gacevicljubisa merged 2 commits into
masterfrom
fix/geth-swap-traefik-v3

Conversation

@gacevicljubisa

Copy link
Copy Markdown
Member

Traefik v3 (k3s >= 1.33) removed the legacy traefik.containo.us API group,
breaking geth-swap installs with ingress.class: traefik:

no matches for kind "IngressRoute" in version "traefik.containo.us/v1alpha1"

Pick traefik.io/v1alpha1 via cluster capabilities when available, falling back
to the legacy group on older clusters. Backward compatible; chart bumped to 0.6.2.

@darkobas2

Copy link
Copy Markdown
Contributor

Change itself looks good — the Capabilities.APIVersions.Has check with the legacy fallback is the right pattern.

One thing I spotted while reviewing: the same legacy API group shows up in charts/beekeeper/templates/clusterrole.yaml (~L49), which still grants RBAC on traefik.containo.us only:

- apiGroups: ["traefik.containo.us"]
  resources: ["ingresses","ingressroutes"]
  verbs: ["get", "list", "watch"]

On Traefik v3 the IngressRoutes are in traefik.io, so that ClusterRole won't cover them — this PR fixes the chart that creates the resource but not the one that reads it. Adding the new group alongside the old one would keep both working:

- apiGroups: ["traefik.containo.us", "traefik.io"]

Happy either way — folded in here or as a follow-up. (Those two files are the only hits for the legacy group in the repo.)

@darkobas2 darkobas2 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — the Capabilities.APIVersions.Has check with the legacy fallback is the right pattern here.

The beekeeper ClusterRole gap I raised in the comment above is being handled in a separate follow-up PR, so nothing to change here.

@gacevicljubisa
gacevicljubisa merged commit f62df92 into master Aug 12, 2026
1 check passed
@gacevicljubisa
gacevicljubisa deleted the fix/geth-swap-traefik-v3 branch August 12, 2026 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants