feat(cmd): add --light-node-limit CLI and config option - #5559
Merged
Conversation
martinconic
requested review from
acud,
akrem-chabchoub,
gacevicljubisa,
janos and
sbackend123
August 12, 2026 08:52
gacevicljubisa
requested changes
Aug 12, 2026
gacevicljubisa
left a comment
gacevicljubisa
left a comment
Member
There was a problem hiding this comment.
I do not see where is the limit is utilised?
gacevicljubisa
approved these changes
Aug 12, 2026
LevilkTheReal
added a commit
to Solar-Punk-Ltd/bee
that referenced
this pull request
Aug 12, 2026
Backport of ethersphere#5559 onto the v2.8.1 tag, unchanged. v2.8.1 already carries LightNodeLimit in libp2p.Options and already honours it, so this adds only the CLI flag and the node.Options passthrough that were missing. The flag defaults to 100, which is defaultLightNodeLimit, so a node started without it behaves exactly as stock v2.8.1 does. Carried here because swarm-stream-loadlab measures the light-node connection ceiling against ethersphere#5556, and that needs the limit configurable on the version we actually run.
akrem-chabchoub
approved these changes
Aug 12, 2026
acud
approved these changes
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Description
This PR exposes the Light Node connection limit via the
--light-node-limitCLI flag andlight-node-limitYAML configuration parameter.Changes for #5556, evaluating performance under increased light node connection capacity requires the ability to configure
LightNodeLimitdynamically. Whilepkg/p2p/libp2palready supportedLightNodeLimitin itsOptionsstruct, the CLI flag andnode.Optionswiring were missing.Resolves #5556
Open API Spec Version Changes (if applicable)
Motivation and Context (Optional)
Related Issue (Optional)
Screenshots (if appropriate):
AI Disclosure