chore: standardize on Node 24 (add .node-version, bump workflows + engines) - #110
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the Dependabot configuration in .github/dependabot.yml to ignore major version updates for the chalk dependency, as chalk v6 requires Node.js v22 or higher, whereas the project currently targets Node.js v20. There are no review comments, and I have no feedback to provide.
- Add .node-version pinning 24.18.0 as the canonical tracked version - Point all setup-node steps at .node-version so CI + publish run the same tracked version as local tooling - Sync .nvmrc to 24 and raise the engines floor to >=24 - Drop the now-obsolete dependabot ignore for chalk majors: chalk 6 requires Node >=22, which the Node 24 base now satisfies
fank
force-pushed
the
claude/ignore-chalk-major
branch
from
August 11, 2026 18:55
ddfe6e8 to
c51e1fe
Compare
fank
changed the title
setup-node and local tooling (nvm, fnm, volta, mise) all read .node-version, so .nvmrc is redundant now that workflows point at it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Standardizes the project on Node 24 so local tooling and CI all run the same tracked version.
.node-versionpinning 24.18.0 as the canonical (and now only) version file; remove.nvmrcsetup-nodestep (npm.ymllint + check-format,publish.yml) at.node-version, so CI and publish run the exact same version as local devenginesfloor to>=24(package.json + package-lock.json root)ignorefor chalk major bumps: chalk 6 requires Node>=22, which the Node 24 base now satisfiesWhy
The original PR (#110) ignored chalk major updates because the project targeted Node 20 and chalk 6 needs
>=22. Now that the base is bumped to Node 24 (>=22), that rule is obsolete — its own comment said to re-evaluate after the Node base reaches 22+. This PR performs that re-evaluation while centralizing versioning on a single.node-versionfile (used by setup-node, nvm, fnm, volta, mise).Notes
Test plan
npm ciclean on Node 24.18.0npm run lintpassesnpm run check-formatpasses.node-version