Skip to content

NXT-18280: SecondaryLabel on ImageItem - #415

Open
dan-ichim-lgp wants to merge 4 commits into
developfrom
feature/NXT-18280
Open

NXT-18280: SecondaryLabel on ImageItem#415
dan-ichim-lgp wants to merge 4 commits into
developfrom
feature/NXT-18280

Conversation

@dan-ichim-lgp

@dan-ichim-lgp dan-ichim-lgp commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Checklist

  • I have read and understand the contribution guide
  • A CHANGELOG entry is included
  • At least one test case is included for this feature or bug fix
  • I have run automated testing and it is passed
  • Documentation was added or is not needed
  • This is an API breaking change

Issue Resolved / Feature Added

Added secondaryLabel prop to limestone/ImageItem so ImageItem can show a second description line under label (same pattern as limestone/Card), for horizontal and vertical orientations.

Resolution

secondaryLabel renders as an additional Marquee line using the existing label styles (ellipsis / marquee on hover), is included in the default aria-label, and is accounted for in fullImage and async placeholders.
This enables a two-line secondary caption under the primary caption without changing existing label behavior. Empty sampler values are omitted so the line is not rendered unintentionally.

Additional Considerations

Links

NXT-18280

Comments

Enact-DCO-1.0-Signed-off-by: Dan Ichim (dan.ichim@lgepartner.com)

@dan-ichim-lgp dan-ichim-lgp self-assigned this Aug 21, 2026
@codecov

codecov Bot commented Aug 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.69%. Comparing base (e64492a) to head (cc5ff71).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #415   +/-   ##
========================================
  Coverage    82.68%   82.69%           
========================================
  Files          153      153           
  Lines         7624     7627    +3     
  Branches      2320     2322    +2     
========================================
+ Hits          6304     6307    +3     
  Misses        1026     1026           
  Partials       294      294           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@daniel-stoian-lgp daniel-stoian-lgp left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.Please add screenshot tests which include the new prop
2. please rerun ss tests after applying all the fixes

Comment thread samples/sampler/stories/default/ImageItem.js Outdated
Comment thread samples/sampler/stories/default/ImageItem.js Outdated
Comment thread styles/variables.less Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants