NXT-18280: SecondaryLabel on ImageItem - #415
Open
dan-ichim-lgp wants to merge 4 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #415 +/- ##
========================================
Coverage 82.68% 82.69%
========================================
Files 153 153
Lines 7624 7627 +3
Branches 2320 2322 +2
========================================
+ Hits 6304 6307 +3
Misses 1026 1026
Partials 294 294 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
dan-ichim-lgp
force-pushed
the
feature/NXT-18280
branch
from
August 21, 2026 13:36
0519ba8 to
c82dfb4
Compare
daniel-stoian-lgp
left a comment
Contributor
There was a problem hiding this comment.
1.Please add screenshot tests which include the new prop
2. please rerun ss tests after applying all the fixes
daniel-stoian-lgp
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Issue Resolved / Feature Added
Added
secondaryLabelprop tolimestone/ImageItemso ImageItem can show a second description line underlabel(same pattern aslimestone/Card), for horizontal and vertical orientations.Resolution
secondaryLabelrenders as an additional Marquee line using the existinglabelstyles (ellipsis / marquee on hover), is included in the defaultaria-label, and is accounted for infullImageand async placeholders.This enables a two-line secondary caption under the primary caption without changing existing
labelbehavior. Empty sampler values are omitted so the line is not rendered unintentionally.Additional Considerations
Links
NXT-18280
Comments
Enact-DCO-1.0-Signed-off-by: Dan Ichim (dan.ichim@lgepartner.com)