Skip to content

fix(client-udp): mark reasks pending after send - #170

Merged
itlezy merged 2 commits into
mainfrom
fix/reask-pending-after-send
Oct 24, 2026
Merged

itlezy merged 2 commits into
mainfrom
fix/reask-pending-after-send

Conversation

@itlezy

@itlezy itlezy commented Oct 24, 2026

Copy link
Copy Markdown
Contributor

Summary

  • preserve the logical source endpoint separately from the actual UDP destination, including buddy-relayed reasks
  • keep reask scheduling pure and open the pending-reply gate only after local socket success
  • keep failed or abandoned sends retryable without recording false remote timeouts or influencing TCP fallback
  • reject duplicate pending completion and cover success, local failure, abandoned work, direct sends, and buddy sends

Validation

  • cargo test -p emulebb-ed2k ed2k_client_udp --lib (116 passed)
  • cargo test -p emulebb-ed2k --features packet-diagnostics (1,188 passed)
  • cargo test -p emulebb-core --features packet-diagnostics (complete unit and integration matrix passed)
  • cargo clippy --workspace --all-targets --locked -- -D warnings
  • cargo fmt --check
  • git diff --check

@itlezy
itlezy merged commit 6d69cee into main Oct 24, 2026
15 checks passed
@itlezy
itlezy deleted the fix/reask-pending-after-send branch October 24, 2026 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant