fix: Add podcasts filter to news search - #101
Merged
Merged
Conversation
Collaborator
Author
|
Review feedback addressed in ccb92c6: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by @drafty
What
podcastsparameter to synchronous and asynchronoussearch_newscalls.sort_by, preserving every prior positional argument slot.Literal["include", "only", "none"], default it to"include", and forward it as the plural query parameter.Why
This implements the approved public Python contract from asknews/api!375 and stories-service!213. The generated
asknews-sdkOpenAPI repository is intentionally out of scope until the gateway is deployed. mcp-service!72 remains blocked until this Python SDK release is available.How I tested
uv run pytest tests/api/test_news.py— 14 passedsort_by, podcasts, *, http_headers; default remainsincludeuv run coverage run -m pytest --junitxml=report.xml— 72 passeduv run coverage report— 89% total coverageuv run ruff check asknews_sdk— passeduv build --wheel— builtasknews-0.13.56-py3-none-any.whlRisk / rollback
Low and limited to the query arguments sent by
search_news. Existing positional callers retain their original parameter mapping, and the new default is the server-approved backward-compatibleincludebehavior. Revert the two feature commits to remove the SDK parameter. Merge timing should follow deployment of the stories and gateway contracts to avoid older servers rejecting the new query parameter.Merging this PR into
maintriggers commitizen release automation and publishes a new patch release of the Pythonasknewspackage to PyPI. No version, changelog, generated-client, or workflow files are changed.