Keyboard navigation - #604
Open
lenemter wants to merge 1 commit into
Open
Conversation
leolost2605
requested changes
Aug 18, 2026
leolost2605
left a comment
leolost2605
left a comment
Member
There was a problem hiding this comment.
A few comments. Also is there a good way to test this? What I did is open the popover of an app, then I can move focus down into the actual dock. But that also only works with the last launcher popover for some reason
| * SPDX-FileCopyrightText: 2026 elementary, Inc. (https://elementary.io) | ||
| */ | ||
|
|
||
| public class Dock.Button : Granite.Bin { |
Member
There was a problem hiding this comment.
Why don't we just use Gtk.Button?
| }); | ||
|
|
||
| var key_controller = new Gtk.EventControllerKey (); | ||
| key_controller.key_pressed.connect (on_key_pressed); |
Member
There was a problem hiding this comment.
Why do we handle this ourselves and don't rely on the gtk focus handling e.g. with overriding move_focus ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards #416
This only addresses the keyboard navigation part, without addressing accessibility issues