Add live multi-diffraction comparison to Show4DSTEM - #244
Merged
bobleesj merged 1 commit intoSep 10, 2026
Merged
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does it solve?
Comparing 4D-STEM reconstructions requires seeing each dataset's diffraction pattern alongside its virtual image at the same scan position or region. Add
compare_dp_mode="all"to the existing Show4DSTEM Multiple view, with shared scan-region Mean/Sum/Max reductions and linked detector interaction.The comparison grid reuses zoom, pan, reset, scale bars and column controls. Region updates use a latest-pending scheduler with acknowledgements, and dragging a diffraction tile updates the common virtual detector while held. Playback is restricted to Single view; switching to Multiple stops playback. Existing selected/average modes remain available.
What should reviewer(s) do?
Verification
This PR follows the
scikit-package workflow for
reproducible scientific software.