Repository navigation
feat(db): introduce new seaweedfs object store usage for e2e - #79
Merged
saswatamcode merged 1 commit intoSep 27, 2026
Merged
Conversation
1 of 2 tasks
saswatamcode
approved these changes
Sep 24, 2026
saswatamcode
left a comment
saswatamcode
left a comment
Collaborator
There was a problem hiding this comment.
Nice generally LGTM, some comments!
| fmt.Sprintf("-s3.port=%d", ports[AccessPortName]), | ||
| "-master.telemetry=false", | ||
| "-webdav=false", | ||
| "-s3.port.iceberg=0", |
Collaborator
There was a problem hiding this comment.
Given some of the wider community efforts, might be good to make iceberge into an option
Contributor
Author
There was a problem hiding this comment.
exposed WithSeaweedFSIceberg() so it can be used if needed.
| } | ||
|
|
||
| func NewSeaweedFS(env e2e.Environment, name, bucket string, opts ...Option) *e2emon.InstrumentedRunnable { | ||
| o := options{image: "chrislusf/seaweedfs:4.47"} |
Collaborator
There was a problem hiding this comment.
Is this the official image for it?
Contributor
Author
There was a problem hiding this comment.
Saumya40-codes
force-pushed
the
introduce-seaweedfs-s3-storage
branch
from
September 25, 2026 04:23
ecae0e3 to
2ddb232
Compare
saswatamcode
approved these changes
Sep 25, 2026
Collaborator
|
@Saumya40-codes can you fix the lint? Will merge then |
Signed-off-by: Saumya Shah <saumyabshah90@gmail.com> refactor a bit make a generalized constant for s3 secret and access key Signed-off-by: Saumya Shah <saumyabshah90@gmail.com> defer close idle conn in ready() check and add -master.telemetry=false so non-related to e2e stuff doesnt start Signed-off-by: Saumya Shah <saumyabshah90@gmail.com> adress pr review changes, add optional iceberg port expose option Signed-off-by: Saumya Shah <saumyabshah90@gmail.com> update deps in examples/thanos and lint changes Signed-off-by: Saumya Shah <saumyabshah90@gmail.com>
Saumya40-codes
force-pushed
the
introduce-seaweedfs-s3-storage
branch
from
September 25, 2026 17:53
2ddb232 to
93acc07
Compare
Saumya40-codes
commented
Sep 26, 2026
|
|
||
| ctx, cancel := context.WithTimeout(context.Background(), time.Second) | ||
| defer cancel() | ||
| exists, err := client.BucketExists(ctx, p.bucket) |
Contributor
Author
There was a problem hiding this comment.
Nit: I think here another viable way could've been hitting /buckets/<name>/ on the filer port → 200 exists, 404 doesn't (seaweedfs/seaweedfs#11461 (comment)) , though ig right now current one with using S3 API directly works right as well.
saswatamcode
approved these changes
Sep 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
introduces support for seaweedfs object storage helper which now can be used as a replacement for the minio, implementation I've ported from is this pr thanos-io/thanos#9037 from thanos so it can be used directly via e2e where its needed.