Repository navigation
fix: validate handshake summary consistency - #19
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a bounded Passpod v0.1 implementation-correctness fix.
The semantic validator now rejects optional handshake summary fields when they contradict the authoritative accepted message history.
Specifically:
lifecycle, when present, must match the lifecycle implied by the final accepted message.terminalClosure.isClosed, when present, must agree with whether the handshake ends inCLOSE.What this does not change
This PR does not modify:
PROPOSE -> CHALLENGE -> AGREE -> CLOSEpasspod-spec-v0.1tagAbsent summary fields remain valid.
Validation
bash tools/check-public-task-repo.shpassingCommits
7e3c050— validate handshake summary consistency4ba9797— changelog entry