test: catch INDEXER_RS_MIN_GRT_PER_30_DAYS drift from indexer-rs upstream - #690
Open
ayushsingh82 wants to merge 1 commit into
Open
test: catch INDEXER_RS_MIN_GRT_PER_30_DAYS drift from indexer-rs upstream#690ayushsingh82 wants to merge 1 commit into
ayushsingh82 wants to merge 1 commit into
Conversation
…ream The const mirrors indexer-rs's [dips.min_grt_per_30_days] table but was only pinned in a docstring, so an upstream change would go unnoticed until an operator ran against stale ceilings. Adds an integration test that fetches indexer-rs's current main branch and fails if the values diverge, and updates the stale docstring reference (the branch it pointed to was merged via indexer-rs#1037 and deleted back in June). Closes edgeandnode#620
Author
|
@MoonBoi9001 opened this against #620 — would appreciate a look when you have a moment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #620.
Summary
INDEXER_RS_MIN_GRT_PER_30_DAYSinbin/dipper-service/src/config.rsmirrors indexer-rs's[dips.min_grt_per_30_days]table, but the only thing pinning it was a docstring referencing a commit. When upstream changes those values, the const silently goes stale and operators run selection against ceilings that no longer match what indexers actually publish.Added
it_min_grt_per_30_days_matches_indexer_rs_upstream, an integration test that fetches indexer-rs's currentmainbranch config and fails if the parsed[dips.min_grt_per_30_days]values diverge from our const, instead of drift going unnoticed until someone checks by hand.Also fixed the docstring's upstream link — it pointed at
mb9/dips-signalling-endpoint, which was merged via indexer-rs#1037 back in June and the branch deleted since, so the link 404s today.No production code changes — purely a new integration test plus a doc-comment fix.
Test plan
cargo test -p dipper-service it_min_grt_per_30_days_matches_indexer_rs_upstream— passes live against indexer-rs's currentmainjust test-unit's filter (tests::minustests::it_) and picked up byjust test-it's filter (tests::it_)just check(cargo clippy -- -D warnings --force-warn deprecated --force-warn dead-code) — cleanjust fmt-check(cargo +nightly fmt --all -- --check) — clean