Repository navigation
Catalogue: what each element needs from the client - #29
Merged
Merged
Conversation
Element.asks?: Ask[] (favourites-to-requests §1): the things a client has to give us before an element can be built on their site. 27 elements carry asks, 22 of them with at least one required; 16 deliberately carry none. Each gallery page lists them under the demo as "What the client needs to give you". check-catalog pins the shape (slug keys unique per element and at most 40 characters, labels at most 120 in sentence case, hints at most 200, at most 6, required a boolean), that every NEEDS_INPUT element has a required ask, and that each built page lists exactly its entry's asks. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First step of favourites-to-requests §1 (library before site, engine, portal). Each element now says what the client has to give us before it can be built on their site. The portal will make each ask a request-form field, and the engine will name a missing required one as a gap.
What changed
AskandElement.asks?: Ask[]insrc/data/catalog.ts, typed exactly as the design note has them ({ key, label, hint?, required? }).Askis exported.hours, countdownends_at/after, mapaddresses, and social-gridhandle/consent.scripts/check-catalog.mjspins:^[a-z][a-z0-9_]*$, at most 40 characters, unique within the elementrequiredis a booleanNEEDS_INPUThas at least one required askasksis added to "Adding an element", to the check's list and to the table of what the website reads.The
superhero-ui-libraryskill is not touched. Another pass updates it.Which elements got asks
Required input (22, pinned in
NEEDS_INPUT):Optional asks only (5):
Deliberately none (16):
Judgement calls to review
triggeris optional, because opening on a button press is a sound default.messageis required.Verification
npm run checkis green: 43 elements, 43 pages built, 27 with asks.required, a lowercase label, a 201-character hint, an emptyasks, seven asks, a page label that differs, and a page missing its required marks.🤖 Generated with Claude Code