Repository navigation
Conversation
We convert read-only verification slices such as ``[]ISomeItem`` to ``[]IAbstractItem`` so V3.2 verification compiles. We also escape encoded regex metacharacters such as ``\x5B`` so valid reference identifiers pass verification. We tolerate whitespace between XML elements and compare decoded round-trip values, allowing equivalent forms such as ``42.0`` and ``42``. We add regression coverage and regenerate affected goldens. Validation: Black, ssort, mypy; 49 unit/golden tests; 38 Go cases; 1,716 V3.2 SDK tests with corrected testdatagen fixtures.
Contributor
|
Hi @chris-koo ! Thanks a lot for this submission! Would you please split it up in separate PRs so that we can review them in isolation? I also expect more problems with V3.2, sosplitting up into smaller fixes would make it easier to figure out better PR titles and descriptions. @aaronzi @empwilli can you please guide @chris-koo if needed since my availability is limited at the moment? |
Member
|
Yes, will do @mristin. Christian is from my team. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #840
Generated V3.2 verification fails to compile when descendant slices
are passed to base-interface slice parameters. Valid reference
identifiers also fail verification, while XML round-trips fail on
formatting whitespace and equivalent lexical representations.
We convert mismatching read-only verification slices, preserving
nil, and retain escaping for encoded regex metacharacters.
We skip formatting whitespace before XML closing tags and compare
decoded round-trip values. Equivalent forms such as
42.0and42can pass while changes to the data still fail.
We format relative diagnostic paths with
as_posix()so Windowsand Linux produce the same error messages.
We add regression coverage and regenerate the affected goldens.
Validation
case.
pass their live tests.
using separately corrected V3.2 testdatagen fixtures.