Repository navigation
feat: show full tool input on tool call cards - #36
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tool call cards now keep the full tool input and render it as a separate Input section above Output when expanded. Previously the input was reduced to a one-line summary,
editold/new text was dropped entirely, and unknown tools were truncated to 120 characters.Part of #2
Closes #35
What changed:
timeline.tskeeps a formattedinputon each tool entry, from both archived messages and livetool_execution_startevents.bashshows the command,read/write/editshow the path plus content or old/new text, and other tools show pretty-printed arguments with no truncation. The header one-line summary is unchanged.WorkbenchControls.tsxrenders labelled Input and Output sections. Running, Done, and Failed states and collapsed-by-default behaviour are unchanged.Verified:
bun install --frozen-lockfilepassedbun run lintpassed, 0 warnings and 0 errorsbun run typecheckpassed across renderer, main, and preload configsbun run test:unitpassed, 71 tests including newkeeps full edit input with old and new textanddoes not truncate long input for other toolsbun run test:integrationpassed, 41 tests including newToolCard.test.tsxchecks that Input and Output render as distinct sections and that a running tool shows Waiting for outputmise run buildpassedbun run test:e2epassed, 43 tests across 5 files against the real Electron appProof:
editcall, expanded the card, and saved.tmp/proof/tool-card-input.png. The capture log recorded section headings["Input","Output"]and card text showing the path,Old: const before = 1;,New: const after = 2;, and outputEdited app.ts successfully. The screenshot shows the same expanded card in the running app. The PNG is kept under.tmp/proof/locally and is not committed, matching the scratch-capture rule for this repo.Known gaps and follow-ups:
editorwriteinput yet, and no copy button or output truncation control. Those remain follow-up slices on Render tool calls as interactive cards #2.