Repository navigation
Conversation
Wire probeKind aws, gcp and azure in runProbe per ADR-0003. Bedrock signs ListFoundationModels with SigV4 (node:crypto, no new deps) using the env credential chain and surfaces the AWS error code in detail. Vertex calls publishers/google/models with project and region from ProbeContext and errors sensibly without them. Azure lists deployments with the api-key header and errors without an endpoint. Mocked-HTTP tests cover the ok and error paths with no live provider keys.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the Bedrock, Vertex and Azure probe kinds to
src/main/probes/sorunProbe()no longer returns "No probe implemented" for provider idsbedrock,vertexandazure-openai. It is the probe-layer slice of the wider work tracked on the parent issue; vault storage for the Vertex project and region, the renderer Keys step fields, and CLI parity stay for later runs.Closes #47
Verification
mise run ci:apppassed in this worktree (typecheck, lint, unit tests including the new cloud probe cases, and the full build).mise run ci:clipassed (typecheck and compiled CLI build). The CLI keeps its existing behaviour in this PR becausecli/src/lib/probes.tsis a separate implementation; parity there is a follow-up in the independent CLI flow.dist/main/probes/aws.js missing, then passed after the implementation and rebuild.Proof comes from a logic-only slice with mocked HTTP and no live provider keys. The fixture server in
scripts/test-probes-cloud.mjsrecords each request and returns canned responses, and the run below is part ofnpm test.Reviewer notes
AWS_ACCESS_KEY_ID,AWS_SECRET_ACCESS_KEY, optionalAWS_SESSION_TOKEN; region fromAWS_REGIONorAWS_DEFAULT_REGION, defaultus-east-1). There is no new dependency and no AWS SDK. The shared credentials file and SSO chain are not read in this slice.runProbe()for Bedrock ignores the vaultapiKeyfield because Bedrock is acloud_credsprovider. The IPC handler still requires a key before probing, so end-to-end Validate wiring for the cloud providers lands with the vault and renderer work on the parent issue.