Skip to content

chore(bots): add topcomment, pakx and mshbd-bot to the bots list - #85

Merged
feruzm merged 1 commit into
mainfrom
chore/bots-list-additions
Aug 25, 2026
Merged

chore(bots): add topcomment, pakx and mshbd-bot to the bots list#85
feruzm merged 1 commit into
mainfrom
chore/bots-list-additions

Conversation

@feruzm

@feruzm feruzm commented Aug 25, 2026

Copy link
Copy Markdown
Member

Adds three accounts to Constants.Bots, the list served by GET /private-api/public/bots and consumed by web and mobile through the SDK's getBotsQueryOptions.

  • topcomment
  • pakx
  • mshbd-bot

Requested additions also included hivebuzz, hivepakistan and ladytoken, which are already in the list.

Inserted in the existing rough alphabetical order. All three resolve to live Hive accounts.

Test plan: dotnet build clean, dotnet test 190/190 passing. Nothing pins the list contents, so no fixtures needed updating.

Summary by CodeRabbit

  • New Features
    • Added mshbd-bot, pakx, and topcomment to the list of recognized bot accounts.

@qodo-code-review

Copy link
Copy Markdown

ⓘ Your Qodo trial ends soon. Ask your workspace admin to set up billing to keep reviews running after the trial. Manage billing

@qodo-free-for-open-source-projects

qodo-free-for-open-source-projects Bot commented Aug 25, 2026

Copy link
Copy Markdown

PR Summary by Qodo

Add topcomment, pakx, and mshbd-bot to Constants.Bots

✨ Enhancement 🕐 10-20 Minutes

Grey Divider

AI Description

• Add three Hive accounts to the API-served bots allowlist (Constants.Bots).
• Preserve the existing rough alphabetical ordering of the bots list.
• Keep SDK consumers in sync via the unchanged GET /private-api/public/bots contract.
Diagram

graph TD
  A([Web/Mobile Client]) --> B["SDK getBotsQueryOptions"] --> C{{"GET /private-api/public/bots"}} --> D(["EcencyApi handler"]) --> E["Constants.Bots (Constants.cs)"]
  D --> F["Bots list JSON"] --> A

  subgraph Legend
    direction LR
    _cli([Client]) ~~~ _svc([Service]) ~~~ _api{{API endpoint}} ~~~ _file["Code/config"]
  end
Loading
High-Level Assessment

The following are alternative approaches to this PR:

1. Move bots list to configuration (appsettings/remote config)
  • ➕ Allows changes without redeploying the API
  • ➕ Easier to manage environment-specific lists if needed
  • ➖ Adds config management surface area and validation needs
  • ➖ Still requires a release process if config is versioned/deployed alongside the app
2. Persist bots list in a database table with admin tooling
  • ➕ Enables audited updates and runtime edits
  • ➕ Scales better if the list grows and needs metadata (reason, added_at)
  • ➖ Overkill for a small static list
  • ➖ Requires migrations, operational dependencies, and access control
3. Derive bot classification dynamically (on-chain signals/heuristics)
  • ➕ Reduces manual curation over time
  • ➕ Potentially more accurate if criteria are well-defined
  • ➖ Complex and error-prone; risk of false positives/negatives
  • ➖ Likely requires ongoing tuning and additional infrastructure

Recommendation: For a small, curated list that changes infrequently, keeping Constants.Bots in code is the simplest and lowest-risk approach. If bot additions become frequent or require auditability, consider moving the list to configuration first (lighter-weight than a DB) before investing in persistent storage or dynamic classification.

Files changed (1) +3 / -0

Enhancement (1) +3 / -0
Constants.csAdd three Hive bot accounts to Constants.Bots +3/-0

Add three Hive bot accounts to Constants.Bots

• Adds "mshbd-bot", "pakx", and "topcomment" to the Constants.Bots allowlist. Entries are inserted to preserve the existing rough alphabetical order so the list remains easy to scan and maintain.

dotnet/EcencyApi/Handlers/Constants.cs

@qodo-free-for-open-source-projects

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

Tip of the day
💡 Did you know, you can hide the parts of a finding you never read, like the evidence or the agent prompt

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

Grey Divider

Qodo Logo

@coderabbitai

coderabbitai Bot commented Aug 25, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 91093983-4353-4324-a168-57f2ba502e9e

📥 Commits

Reviewing files that changed from the base of the PR and between 3cf322f and 1b3a12f.

📒 Files selected for processing (1)
  • dotnet/EcencyApi/Handlers/Constants.cs

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The public Constants.Bots account list now includes mshbd-bot, pakx, and topcomment.

Changes

Bot account list

Layer / File(s) Summary
Update bot account entries
dotnet/EcencyApi/Handlers/Constants.cs
Adds mshbd-bot, pakx, and topcomment to Constants.Bots.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 1b3a1

This change only adds three bot accounts to the published bot list, with no actionable merge-blocking risk remaining after normal checks and review.

Poem

A rabbit reviewed the bot list today
Three new names hopped into play
mshbd-bot and pakx joined the track
topcomment sprang right back
The constants now keep every hare in array

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely identifies the three bot accounts added to the bots list, which is the main change in the pull request.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/bots-list-additions

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@qodo-code-review

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

Tip of the day
💡 Did you know, you can hide the parts of a finding you never read, like the evidence or the agent prompt

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

Grey Divider

Qodo Logo

@feruzm
feruzm merged commit b08b5b4 into main Aug 25, 2026
4 checks passed
@feruzm
feruzm deleted the chore/bots-list-additions branch August 25, 2026 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant