Skip to content

feat(micro-utilities): add is-upper-case to replacements - #1117

Open
kamalesh404 wants to merge 1 commit into
e18e:mainfrom
kamalesh404:feat/micro-utilities-is-upper-case
Open

kamalesh404 wants to merge 1 commit into
e18e:mainfrom
kamalesh404:feat/micro-utilities-is-upper-case

Conversation

@kamalesh404

@kamalesh404 kamalesh404 commented Sep 13, 2026

Copy link
Copy Markdown

🔗 Linked issue

closes: #1004

📚 Description

adds is-upper-case to the micro-utilities manifest (snippet + module mapping), following the same shape as the merged is-lower-case entry. The implementation is the locale-aware check suggested in the issue for the deprecated is-upper-case package: a string is entirely upper case when it equals its toLocaleUpperCase form and contains cased characters.

@gameroman

Copy link
Copy Markdown
Contributor

Please fill in the PR template correctly and fix formatting

@kamalesh404

Copy link
Copy Markdown
Author

Thanks for the review! I've updated the PR body to follow the template (linked issue + description). Could you point me to which formatting issues you'd like fixed in the manifest?

@gameroman

Copy link
Copy Markdown
Contributor

Thanks for the review! I've updated the PR body to follow the template (linked issue + description). Could you point me to which formatting issues you'd like fixed in the manifest?

image

Adds the snippet::is-upper-case replacement and the is-upper-case
module mapping, following the same shape as the merged is-lower-case
entry. The implementation is the locale-aware check suggested in
e18e#1004 (deprecated package): a string is entirely upper case when it
equals its toLocaleUpperCase form and contains cased characters.
@kamalesh404
kamalesh404 force-pushed the feat/micro-utilities-is-upper-case branch from f8d25a4 to 2dca7b7 Compare September 20, 2026 10:20
@kamalesh404

Copy link
Copy Markdown
Author

Thanks for the screenshot — that made it clear. I rebuilt the branch on current main: the whole-file key re-sort is gone (the earlier push had rewritten every entry to a different key order and added a stray id field to the mapping). The diff is now a minimal 11-line insertion — the snippet::is-upper-case entry with id/type/description/example key order and the is-upper-case mapping under mappings with type/moduleName/replacements, both placed alphabetically, matching the merged is-lower-case entry. The example now also uses the locale-aware implementation suggested in #1004.

@43081j

43081j commented Sep 20, 2026

Copy link
Copy Markdown
Contributor

Evidently we're talking to an agent here. It is important PRs are submitted by someone who is going to be responsible for the change, not their agent. So can you reply at some point yourself, not via your agent, to ensure this isn't fully automated.

If you're not able to do that because a human isn't in the loop, let us know and we can deal with it differently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Replacement]: is-upper-case

3 participants