Skip to content

[major] Fix Action Icon size #2540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PelayoFelgueroso wants to merge 10 commits into
base: master
Choose a base branch
from
Open

[major] Fix Action Icon size #2540

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
e5a3a56
Fix ActionIcon size
PelayoFelgueroso Sep 11, 2026
6db1885
remove aspect-ratio, and use width and height instead
PelayoFelgueroso Sep 14, 2026
ae61a7c
fix failing tests
PelayoFelgueroso Sep 14, 2026
889f53f
Remove height and use width with aspect-ratio
PelayoFelgueroso Sep 17, 2026
7064461
remove unneeded test
PelayoFelgueroso Sep 17, 2026
8d3171a
use height instead of aspect-ratio
PelayoFelgueroso Sep 17, 2026
3ac5ff6
Merge branch 'master' into PelayoFelgueroso/fix-actionIcon
PelayoFelgueroso Sep 17, 2026
814a7dc
add flex-shrink to avoid distorted width
PelayoFelgueroso Sep 30, 2026
6fe66a2
Merge branch 'master' into PelayoFelgueroso/fix-actionIcon
PelayoFelgueroso Sep 30, 2026
859a7c8
Merge branch 'PelayoFelgueroso/fix-actionIcon' of https://github.com/…
PelayoFelgueroso Sep 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/lib/src/action-icon/ActionIcon.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,9 @@ const ActionIconContainer = styled.div<
display: flex;
justify-content: center;
align-items: center;
width: ${({ size }) => getSize(size)};
height: ${({ size }) => getSize(size)};
aspect-ratio: 1 / 1;
flex-shrink: 0;
text-decoration: none;
border-radius: ${({ shape, size }) => getBorderRadius(shape, size)};
background-color: ${({ color }) => getBackgroundColor(color)};
Expand Down
11 changes: 5 additions & 6 deletions packages/lib/src/action-icon/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,10 +49,10 @@ const borderRadiusMap = {
};

const sizeMap = {
xsmall: "var(--height-s)",
small: "var(--height-m)",
medium: "var(--height-xl)",
large: "var(--height-xxxl)",
xsmall: "24px",
small: "32px",
medium: "40px",
large: "56px",
xlarge: "72px",
xxlarge: "80px",
};
Expand Down Expand Up @@ -91,8 +91,7 @@ export const getBorderRadius = (shape: ActionIconPropTypes["shape"], size: Actio
return "100%";
};

export const getSize = (size: ActionIconPropTypes["size"]) =>
size && sizeMap[size] ? sizeMap[size] : "var(--height-xl)";
export const getSize = (size: ActionIconPropTypes["size"]) => (size && sizeMap[size] ? sizeMap[size] : "40px");

export const getIconSize = (size: ActionIconPropTypes["size"]) =>
size && iconSizeMap[size] ? iconSizeMap[size] : "var(--height-s)";
Expand Down
Loading