chore(release): version packages - #43
Open
github-actions[bot] wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
@dunky.dev/react-dialog@0.3.0
Minor Changes
#40
148ee66Thanks @ivanbanov! -Dialog.Contentnow renders a<div>carrying thedialog(oralertdialog) role instead of the native<dialog>element. Consumers stylingdialog { ... }should target the part directly (or its role), and a forwarded ref is now anHTMLDivElement;...propsacceptComponentProps<'div'>.The dialog window is the initial focus target — focusable in script, out of the tab order — which needs
tabindex="-1", and HTML states that thetabindexattribute must not be specified ondialogelements. The native element would only pay off throughshowModal(), and this contract deliberately keeps modality, dismissal, and focus in the core machine rather than splitting authority with the browser's built-in behavior — so the element brought nothing but a conformance violation. Nothing about the exposed semantics changes: the same role,aria-modal, name, description, and focus behavior as before. UA<dialog>resets (position: static,border: none) are no longer needed in consumer styles.