Skip to content

fix(react): preventDefault.bind in the normalize - #64

Merged
ivanbanov merged 2 commits into
mainfrom
react
Aug 18, 2026
Merged

fix(react): preventDefault.bind in the normalize#64
ivanbanov merged 2 commits into
mainfrom
react

Conversation

@ivanbanov

Copy link
Copy Markdown
Member

Extracts everything react-related from the solid branch (#32) so that PR stays solid-only:

  • fix(react) — the payload adapters handed out a detached native preventDefault, which throws "illegal invocation" when called; they now bind it to its event. Regression-tested.
  • refactor(sandbox) — the react demo's inline style objects move into sandbox/shared/src/styles.css and the markup renders classes. The solid demo on feat(solid): Solid 2 integration #32 imports the same file, so the two web sandboxes share one look.

The files are byte-identical with the solid branch, so rebasing #32 onto main after this merges drops them from its diff cleanly.

🤖 Generated with Claude Code

@vercel

vercel Bot commented Aug 18, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
dunky-state-machine Skipped Skipped Aug 18, 2026 8:24pm

ivanbanov and others added 2 commits August 18, 2026 22:24
A detached native preventDefault throws "illegal invocation" — the payload
adapters now hand out a closure that calls it with the event as `this`.
Extracted from the solid branch (#32), where it landed as part of e51bea0.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
sandbox/shared/src/styles.css replaces the inline style objects — the react
demo renders classes, and the solid demo (#32) imports the same file, so the
two web sandboxes share one look. Kept byte-identical with the solid branch
for a clean rebase.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
ivanbanov added a commit that referenced this pull request Aug 18, 2026
Same behavior as the arrow-closure wrapper, one line — mirrors the react
normalizer on #64.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@ivanbanov ivanbanov changed the title fix(react): react-side changes extracted from the solid branch fix(react): preventDefault.bind in the normalize Aug 18, 2026
@ivanbanov
ivanbanov merged commit 6f566bf into main Aug 18, 2026
7 of 8 checks passed
@ivanbanov
ivanbanov deleted the react branch August 18, 2026 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant