Repository navigation
Normalize GPU VRAM against registered capacities - #279
Merged
Merged
Conversation
peterschmidt85
marked this pull request as ready for review
October 26, 2026 11:18
jvstme
approved these changes
Oct 28, 2026
| KNOWN_TPUS as KNOWN_TPUS, | ||
| correct_gpu_memory_gib as correct_gpu_memory_gib, | ||
| find_accelerators as find_accelerators, | ||
| get_gpu_memory_gib as get_gpu_memory_gib, |
Collaborator
There was a problem hiding this comment.
(nit) Is this necessary? I think we usually only export gpuhunt utility functions if we need to call them in dstack
Collaborator
There was a problem hiding this comment.
(nit) You've switched from correct_gpu_memory_gib to get_gpu_memory_gib throughout the codebase. The only behavioral difference is that get_gpu_memory_gib doesn't round the memory of unknown GPUs to a whole number. Wouldn't it make sense to round it? I don't think any GPU models have a nominal memory that isn't a whole number, so we probably don't want to display fractional values in dstack.
If you decide to round everywhere, I don't see a reason to keep both correct_gpu_memory_gib and get_gpu_memory_gib. I'd keep only correct_gpu_memory_gib.
peterschmidt85
marked this pull request as draft
October 29, 2026 08:52
peterschmidt85
marked this pull request as ready for review
October 29, 2026 08:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Offers can report VRAM that differs from the GPU SKU's known capacity. This makes expected-VRAM filters unreliable and splits equivalent offers into separate groups when grouping by GPU.
KNOWN_ACCELERATORS, accepting a correction only when exactly one capacity matches the existing ±7% window.Examples, in GiB per GPU:
Compatibility:
gpu_partitions,gpu: MI325X:288GBwill fail to resolve; change it togpu: MI325X:256GB. Baregpu: MI325Xneeds no edit and now resolves to 256GB.