Repository navigation
docs(ci): update dependabot-repair comments for the redirect sync pass (#986) - #989
Merged
Merged
Conversation
#986) The comments at the repair step still said the binding-redirect class never runs from the workflow_run trigger. The unconditional redirect sync pass added in #985 now rewrites stale redirects on every run and reports through RedirectSync, so describe both passes, why neither reaches the beyond-known-weak filter, and that WrittenPath covers every pass. Comment-only; no behavior change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Gw2R64FrQkj5f88mFAe3KA
R7 asserted the old phrase 'not reachable from the workflow_run trigger', which the comment rewrite removed. Assert the new wording instead: that redirect rewrites never count toward beyond-known-weak, and that supplying -CandidateUpgrade with the record kept means the clause must be restored. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Gw2R64FrQkj5f88mFAe3KA
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.github/workflows/dependabot-repair.yml(the "Repair package manifest consistency" step). There are no changes to YAML keys, expressions or script lines.-CandidateUpgradereconciliation pass, which this trigger still never runs.RedirectSync.beyond-known-weakfilter, and thatWrittenPathcovers every pass.Why
The previous comments said the binding-redirect class is not reachable from the
workflow_runtrigger. #985 made that false. The behavior is correct; only the comments misled a reader.Verification
scripts/dependencies/Repair-PackageManifestConsistency.ps1lines 447-495:RedirectSync, separate fromVerification[].Report.Repair.WrittenPath.git difftouches comment lines only.Review policy exception
The feature-review rule
modified-workflow-needs-green-runcannot be satisfied for this file. The workflow runs only onworkflow_runfordependabot/branches and has noworkflow_dispatch, so it cannot run against this branch head. The maintainer approved an exception for this comment-only change, and the next Dependabot PR exercises the file.Risks and Mitigations
GitHub Auto-close
🤖 Generated with Claude Code
https://claude.ai/code/session_01Gw2R64FrQkj5f88mFAe3KA