Skip to content

Fix visibility hidden edge case - #45

Closed
test-codeop wants to merge 2 commits into
doublebyte1:fix-workflowfrom
test-codeop:uncover-agent-2574974461
Closed

test-codeop wants to merge 2 commits into
doublebyte1:fix-workflowfrom
test-codeop:uncover-agent-2574974461

Conversation

@test-codeop

Copy link
Copy Markdown
Collaborator

Overview

There is an edge case in the visibility hidden logic where an error can be thrown, I believe if the user requests collections/{id}

In the sample pygeoapi-config.yml set the config to

    canada-metadata:
        type: collection
        visibility: hidden

and go to http://localhost:5005/collections/canada-metadata?f=json and an error will be thrown.

This fixes it by not skipping hidden collections if the specific dataset was requested. i.e. skip the dataset for collections/ but not collections/{id}

I also added a test to ensure it works if all resources are hidden

Related Issue / discussion

N/A

Additional information

This is the error at http://localhost:5005/collections/canada-metadata?f=json that will be fixed

image

Dependency policy (RFC2)

  • I have ensured that this PR meets RFC2 requirements

Updates to public demo

Contributions and licensing

(as per https://github.com/geopython/pygeoapi/blob/master/CONTRIBUTING.md#contributions-and-licensing)

  • I'd like to contribute [feature X|bugfix Y|docs|something else] to pygeoapi. I confirm that my contributions to pygeoapi will be compatible with the pygeoapi license guidelines at the time of contribution

  • I have already previously agreed to the pygeoapi Contributions and Licensing Guidelines

  • Original PR: Fix visibility hidden edge case geopython/pygeoapi#2330

  • Reproduced automatically by test_create_pr.py to exercise the Detect AI workflow.

@test-codeop test-codeop closed this by deleting the head repository Oct 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant