Repository navigation
Fix visibility hidden edge case - #45
Closed
test-codeop wants to merge 2 commits into
Closed
test-codeop wants to merge 2 commits into
test-codeop wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
There is an edge case in the visibility hidden logic where an error can be thrown, I believe if the user requests collections/{id}
In the sample
pygeoapi-config.ymlset the config toand go to http://localhost:5005/collections/canada-metadata?f=json and an error will be thrown.
This fixes it by not skipping hidden collections if the specific dataset was requested. i.e. skip the dataset for
collections/but notcollections/{id}I also added a test to ensure it works if all resources are hidden
Related Issue / discussion
N/A
Additional information
This is the error at http://localhost:5005/collections/canada-metadata?f=json that will be fixed
Dependency policy (RFC2)
Updates to public demo
Contributions and licensing
(as per https://github.com/geopython/pygeoapi/blob/master/CONTRIBUTING.md#contributions-and-licensing)
I'd like to contribute [feature X|bugfix Y|docs|something else] to pygeoapi. I confirm that my contributions to pygeoapi will be compatible with the pygeoapi license guidelines at the time of contribution
I have already previously agreed to the pygeoapi Contributions and Licensing Guidelines
Original PR: Fix visibility hidden edge case geopython/pygeoapi#2330
Reproduced automatically by
test_create_pr.pyto exercise the Detect AI workflow.