Skip to content

fix(publishing-queue): copy icon polish and delete-asset button consistency (#36897) - #36908

Open
hmoreras wants to merge 1 commit into
mainfrom
issue-36897-fixes
Open

fix(publishing-queue): copy icon polish and delete-asset button consistency (#36897)#36908
hmoreras wants to merge 1 commit into
mainfrom
issue-36897-fixes

Conversation

@hmoreras

@hmoreras hmoreras commented Aug 5, 2026

Copy link
Copy Markdown
Member

Closes #36897.

Summary

  • Copy Bundle Id icon — enlarged the click target (w-4 h-4w-5 h-5) so the icon is comfortable to hit at standard admin zoom.
  • Delete asset button (bundle detail dialog) — compact 32×32 rounded button with an 18px material-symbols-rounded icon; before, the icon was mis-sized inside default PrimeNG small-button padding and looked oversized/misaligned.
  • Remove asset confirmation — dropped p-button-danger on the accept button (now primary), matching the modernized dialog styling on this portlet.
  • Terminology consistency in the select-bundle dialog:
    • Bundle Remove flow: dialog header now uses a new key publishing-queue.select-bundle.remove.confirm.header = "Remove bundles?" (was reusing the generic "Delete" key) and the accept button consistently says "Remove".
    • Asset Delete flow: header/message keys publishing-queue.asset-list.remove-confirm.header/.message reworded to "Delete asset from bundle?" / "Are you sure you want to delete …", and the accept button uses a new publishing-queue.delete = "Delete". The same .remove-confirm.* keys are shared with dot-publishing-queue-asset-list-dialog, so both dialogs get the aligned wording.

Test plan

  • Open the Publishing Queue portlet, hover a bundle row and click the copy icon — target is easy to hit, tooltip clears on mouseleave.
  • Open a bundle in the select-bundle dialog — the per-row delete button is compact and its delete icon is proportional to the row.
  • Click the per-row delete button on an asset:
    • Tooltip reads "Delete from bundle".
    • Confirmation dialog header reads "Delete asset from bundle?".
    • Message reads "Are you sure you want to delete …".
    • Accept button reads "Delete", styled as primary (not danger).
  • Select one or more bundles and click Remove:
    • Confirmation header reads "Remove bundles?".
    • Message reads "Are you sure you want to remove {N} bundle(s)?".
    • Accept button reads "Remove".
  • Verify no existing i18n consumer regressed: publishing-queue.delete.confirm.header / .message are still used by the main bundle table Delete flow — unchanged there.

Notes

🤖 Generated with Claude Code

…elete terminology

- Delete asset button in select-bundle dialog: compact 32x32 with 18px icon
  (was uneven with default PrimeNG padding and mis-sized material-symbols).
- Remove asset confirmation: drop danger styling on accept, use primary.
- Terminology: use "Remove" consistently for the bundle remove flow
  (header now "Remove bundles?", accept "Remove") and "Delete" consistently
  for the asset delete flow (header "Delete asset from bundle?", accept "Delete").
- Table copy-button size bump w-4/h-4 -> w-5/h-5 for parity with hover target.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@claude

claude Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Claude finished @hmoreras's task in 2m 0s —— View job


Code Review

  • Read PR diff and changed files
  • Cross-check i18n keys against consumers & specs
  • Verify styling/terminology consistency

New Issues

  • 🟡 Medium: dot-publishing-queue-asset-list-dialog.component.ts:210 — Inconsistent accept-button styling between the two "delete asset from bundle" dialogs. The PR drops p-button-danger (→ primary) on the identical confirmation in dot-publishing-queue-select-bundle-dialog.component.ts:408-409, but this dialog still sets acceptButtonStyleClass: 'p-button-danger'. Both use the same shared publishing-queue.asset-list.remove-confirm.* keys and the same "Delete" accept label, so the user sees a red button in one place and a primary button in the other for the same action. The PR summary states the accept button is "now primary" — that only landed in one of the two dialogs. Fix this →

Notes (non-blocking)

  • dot-publishing-queue-asset-list-dialog.component.spec.ts:57-63 still declares the old strings ('Remove asset from bundle?', 'publishing-queue.remove': 'Remove') in its i18n mock map. Tests don't assert on acceptLabel, and the mock returns the key itself when absent, so nothing fails — but the mock map is now stale relative to the shipped wording, and the new publishing-queue.delete label has no assertion. Consider updating the mock and adding a label assertion when convenient.
  • i18n keys verified consistent: select-bundle.remove.confirm.header = "Remove bundles?", asset-list.remove-confirm.header/.message reworded to "Delete …", and publishing-queue.delete = "Delete" all present in Language.properties. The publishing-queue.delete.confirm.* / publishing-queue.history.kebab.delete keys remain used by the main table Delete flow (dot-publishing-queue-table.component.ts:275,280) — unchanged, no regression.

The styling/CSS-utility changes (w-5 h-5, h-8! w-8! p-0!, text-lg! leading-none!) are presentation-only and look correct.
• branch issue-36897-fixes

@github-actions github-actions Bot added the Area : Frontend PR changes Angular/TypeScript frontend code label Aug 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area : Frontend PR changes Angular/TypeScript frontend code

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

[DEFECT] Publishing Queue copy icon polish

1 participant