Repository navigation
Conversation
Owner
|
IMHO, Download share of ARM Windows is still too small. I'm planning to add ARM Windows wheels with dropping x86 MacOS. It's going to happen when
|
Author
|
@dofuuz thanks for the feedback. The reason why I created this PR is because new laptops based on Nvidia RTX Spark will hit the market shortly, and we'll suddenly have a large influx of Windows ARM64 users. It's a small change that will make the experience a lot smoother for those users. Let me know what you think. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You already added tests for Windows ARM64 in 1227ac6, so here's a fairly straightforward PR to add the wheels too (just to make it easier for you vs. opening an issue about it.)
I skipped cp39 and cp310 for win_arm64 for two reasons: