Skip to content

Proposal: should missing local images links fail the build? #200

Description

@kjantzer

Currently they do....

However, GitHub supports linking to repo images in the README markdown files, like so:

# <img src="./icons/32x32.png"> Bathroom Status Chrome Extension (example)

However, this currently fails the build because of line 64 in fix_html.js

throw new Error(${base}: Unknown reference '${origUrl}')

What do you think about changing the fatal error to a console.error so that the docs still build. I'd rather have a broken image then no docs at all.

Side note:
I looked around the Metalsmith docs to see if there was a way of copying the local image to the build directory, but I didn't find anything solution.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions