Repository navigation
feat(core): read what the default build has from the schema - #3
Merged
Merged
Conversation
…ull tag releases work Releases since the full tag say in_default_build for every plugin. A plugin outside it (a notifier, rfc2136, yandexcloud, namecheap) points to the -full image, and ping_url no longer does, nor does it add a ping tag. Schemas of older releases have no such field and are read as before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dnspatch#90 adds the
fullbuild tag and a lighter default build. This makes the builder read what a release has from its schema, instead of assuming it.schema.jsonof a release since then saysin_default_buildfor every plugin. A plugin outside it (a notifier,rfc2136,yandexcloud,namecheap) points to the-fullimage; the config constructor says so under the provider cards.ping_urlis in every build of those releases, so it no longer points to-fulland no longer adds apingtag.ping_urland the notifiers only in-full. The bundledv0.4.4-rc.1schema behaves exactly as it did.-tags fulland the schema it generates.Safe to merge before the dnspatch release: nothing changes until a release with the new schema is fetched (
npm run schemas).Linear: DNS-79
Part of DNS-79